From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82BA7C4828F for ; Fri, 2 Feb 2024 22:51:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 339DF10F13B; Fri, 2 Feb 2024 22:51:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iov5uErG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E4A610F13B for ; Fri, 2 Feb 2024 22:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706914260; x=1738450260; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=22Fmfh5JqFjLPVBv12uB/Q+CpWxrvlBHDqlhld/3MXc=; b=iov5uErG0a4AN9ULLVITBCxs8LFc8GtRN7U25HT+8wX6SifgJOq+GbyK 80sNCVm5lpU1zDoF3+HOK86PF+U2m/lmZMUmTUWuP5kFG7eSRw6qUDr+Q 7+OccBjipIUsrUaYszd1stRb0ChdS1WMCdGuPbyWQlEgBJMil2YgvsV/g 3DbLUqAOvGOGKKzZTipmpL4n7YauePIUzSrv+CWsCZdWWiutaOMntw/Dn cn97Zenu509vwt58WizufTNXyZO6TYL31JYnf0JFCTwwrMv45ZfByOw2P 7BCpwCilY7qqaEWAnZkg0s1LBCmbjFH997u8E3f+nbU7W4Q+WVfh2swPX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="153719" X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="153719" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 14:43:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="823332002" X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="823332002" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 02 Feb 2024 14:43:52 -0800 Received: by stinkbox (sSMTP sendmail emulation); Sat, 03 Feb 2024 00:43:51 +0200 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org, Andrzej Hajda , Nirmoy Das , Paz Zcharya Subject: [PATCH v4 03/16] drm/i915: Remove ad-hoc lmem/stolen debugs Date: Sat, 3 Feb 2024 00:43:27 +0200 Message-ID: <20240202224340.30647-4-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240202224340.30647-1-ville.syrjala@linux.intel.com> References: <20240202224340.30647-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: Ville Syrjälä Now that intel_memory_regions_hw_probe() prints out each and every memory region there's no reason to have ad-hoc debugs to do similar things elsewhere. Reviewed-by: Andrzej Hajda Reviewed-by: Nirmoy Das Tested-by: Paz Zcharya Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 ---- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 3 --- 2 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c index d2440c793f84..ee237043c302 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c @@ -828,7 +828,6 @@ static const struct intel_memory_region_ops i915_region_stolen_smem_ops = { static int init_stolen_lmem(struct intel_memory_region *mem) { - struct drm_i915_private *i915 = mem->i915; int err; if (GEM_WARN_ON(resource_size(&mem->region) == 0)) @@ -844,9 +843,6 @@ static int init_stolen_lmem(struct intel_memory_region *mem) !io_mapping_init_wc(&mem->iomap, mem->io.start, resource_size(&mem->io))) goto err_cleanup; - drm_dbg(&i915->drm, "Stolen Local DSM: %pR\n", &mem->region); - drm_dbg(&i915->drm, "Stolen Local memory IO: %pR\n", &mem->io); - return 0; err_cleanup: diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index 6f96a6b70601..af357089da6e 100644 --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c @@ -273,9 +273,6 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) if (err) goto err_region_put; - drm_dbg(&i915->drm, "Local memory: %pR\n", &mem->region); - drm_dbg(&i915->drm, "Local memory IO: %pR\n", &mem->io); - if (io_size < lmem_size) drm_info(&i915->drm, "Using a reduced BAR size of %lluMiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS.\n", (u64)io_size >> 20); -- 2.43.0