From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CC19C4828D for ; Mon, 5 Feb 2024 15:31:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60CDD10EB79; Mon, 5 Feb 2024 15:31:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DEXYg815"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3259110F87C for ; Mon, 5 Feb 2024 15:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707147085; x=1738683085; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=Eqib9+xbXHuUQJpWlBK+mKYnrwGR+EI7WKTO3MmoMOI=; b=DEXYg8155qAhLQgcLLKD+7FZtO3XqNHbanyZ+sP3H9iB/v16n/DcSAkE 5WlUdTOSpb38zZZUmBEmcY53fLUK5ZoR3zQ7EehsSPiA9oqLVe9LyIwlk ZiG/Oc0SBabxR+JuJuK8f62VAGsapJ6VMBsic1LCxXs+Euxk6cACMFkvy ew/xZod3E77n8+XiIE8JcyfRV7Cv2ZJ0dJXILDvWgR3/u96bHR4IRdAZ2 uyz8NUQw7NyVknumJjBmeTwPThw/F7QulNhI7oZkncx5kZJAfp6UPU/7F 4U2oEMMNoGVI8tjtZb8MXbUaQjMdvvXlReuipwWxacV6ii0UGET8lPW/F g==; X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="4337044" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="4337044" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 07:31:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="23984629" Received: from vgolodni-mobl.ger.corp.intel.com (HELO mwauld-mobl1.intel.com) ([10.252.0.151]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 07:31:19 -0800 From: Matthew Auld To: intel-xe@lists.freedesktop.org Subject: [PATCH] drm/xe/display: fix i915_gem_object_is_shmem() wrapper Date: Mon, 5 Feb 2024 15:31:11 +0000 Message-ID: <20240205153110.38340-2-matthew.auld@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" shmem ensures the memory is cleared on allocation, however here we are using TTM, which doesn't natively support shmem (other than for swap), but instead just allocates normal system memory. And we only zero such memory for userspace allocations. In the case of intel_fbdev we are missing the memset_io(). Signed-off-by: Matthew Auld --- drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h index 68d9f6116bdf..777c20ceabab 100644 --- a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h +++ b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h @@ -10,7 +10,7 @@ #include "xe_bo.h" -#define i915_gem_object_is_shmem(obj) ((obj)->flags & XE_BO_CREATE_SYSTEM_BIT) +#define i915_gem_object_is_shmem(obj) (0) /* We don't use shmem */ static inline dma_addr_t i915_gem_object_get_dma_address(const struct xe_bo *bo, pgoff_t n) { -- 2.43.0