Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Anshuman Gupta <anshuman.gupta@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH] drm/xe/pm: hide d3cold sysfs threshold
Date: Wed, 21 Feb 2024 17:10:09 +0000	[thread overview]
Message-ID: <20240221171008.196673-2-matthew.auld@intel.com> (raw)

There are known deadlocks and lockdep splats with d3cold and dgpu, which
is why it is disabled by default. However we still don't want CI or
actual users trying to override the DEFAULT_VRAM_THRESHOLD and then end
up enabling d3cold support. For now keep the sysfs hidden if
DEFAULT_VRAM_THRESHOLD is zero.

References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1246
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index ab283e9a8b4e..829f165e30b4 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -189,7 +189,8 @@ void xe_pm_init(struct xe_device *xe)
 	xe->d3cold.capable = xe_pm_pci_d3cold_capable(xe);
 
 	if (xe->d3cold.capable) {
-		xe_device_sysfs_init(xe);
+		if (DEFAULT_VRAM_THRESHOLD)
+			xe_device_sysfs_init(xe);
 		xe_pm_set_vram_threshold(xe, DEFAULT_VRAM_THRESHOLD);
 	}
 
-- 
2.43.0


             reply	other threads:[~2024-02-21 17:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 17:10 Matthew Auld [this message]
2024-02-21 17:16 ` ✓ CI.Patch_applied: success for drm/xe/pm: hide d3cold sysfs threshold Patchwork
2024-02-21 17:16 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-21 17:17 ` ✓ CI.KUnit: success " Patchwork
2024-02-21 17:27 ` ✓ CI.Build: " Patchwork
2024-02-21 17:28 ` ✓ CI.Hooks: " Patchwork
2024-02-21 17:29 ` ✓ CI.checksparse: " Patchwork
2024-02-21 17:50 ` ✓ CI.BAT: " Patchwork
2024-02-21 17:52 ` [PATCH] " Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240221171008.196673-2-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox