From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4EECC54E4A for ; Thu, 22 Feb 2024 14:01:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FC1B10E955; Thu, 22 Feb 2024 14:01:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="rHwkiBOm"; dkim-atps=neutral Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38B7E10E7D1 for ; Wed, 21 Feb 2024 20:02:12 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7beda6a274bso41471039f.2 for ; Wed, 21 Feb 2024 12:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708545731; x=1709150531; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hW/eD+217SwbFSrd+7OlcqgqqQaX2xcDsJgsLrnW3ms=; b=rHwkiBOm9IqPFna+mTfLShXLJ1T1b/BoVvF2N+5Z6vglGkrwugmv+oIQbwPNv587YT qI1DiNdeZgsFZbcro3ciC710R8kAMmwY/VWEwy5o3mjuSQI3R4tZg7pm6Ojb7mnzGMX5 ztwTUepI5rLP2DvfyThVzgsBR7CWgIfkgztBJI+2g+DJVb39BNlee5XdWjLsEcHztSf9 fn8NxiTq5Oi9+Z2xhmiKDD3yphfwHL22MEB+opH1CpQYddFZO73MDK3yhBdsE1cUd5b8 4LSrl5k5EMmVp8iXvHxCzhm//O4J6F+SI2LPjkbcyZyEeRlqSM8c+trrX9R6gbxJBCMh h4iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708545731; x=1709150531; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hW/eD+217SwbFSrd+7OlcqgqqQaX2xcDsJgsLrnW3ms=; b=DMA8bo34Hq8avLmlKM1i0+zS+dJO2T+wIaFNhGiroM0C9qjkw6pRuVuYa6e8jdaE4n prSak4WhHZE7NrGogAnxWYIBs+wGA44A2CRbA75vh7kCbVI+sI7ZVfU+bjF/5ZeEJuza HMhBPiV3H1Senlb/8cWsxPl/Z+Z6cwuXCZCsFtoOMwOW24mDlr/e6yMOUo3wrDMtu85l X+qjGKNSx8xFocDhjOhMvvV+KTB7S3R2yl2ybLCI02SZapN1PggmJuRFSU/OGZiKDy5w 59sgLEPKFtE64hSgehNJr3ulArSjL/r8GMWh+4TOL8XNrnRugSj4ENSXfxdtrrRy8uKS uvBw== X-Forwarded-Encrypted: i=1; AJvYcCUdwih5F/96ajl7lgFk/n2V3qFda+XF9j8dF0mmAqBHE5EL1V6E+QmPWLR8S5C8MIvv28wGtgM7Sx501pcT8nQUXOd7x5NJy4EjjhBwZrk= X-Gm-Message-State: AOJu0YxSznrcsDRMPAQwk+nyhwEbvkBzbOB+4rwQlzAmYTHHkLZlPceF xhE9SCq/ZTwNSocQMFXoAJ7h5tco4cjltdbQ/V795RfOp6vMjpFWyaIXQCkj9g== X-Google-Smtp-Source: AGHT+IG39BbcKPU1il8vkTs2a8eXqdOP0Ld0XjhZHI7TKaGTsFOA7fu8B9CXr669y5rm4dsiJ0Wmbg== X-Received: by 2002:a5d:929a:0:b0:7c7:4d7e:de87 with SMTP id s26-20020a5d929a000000b007c74d7ede87mr10763875iom.1.1708545731187; Wed, 21 Feb 2024 12:02:11 -0800 (PST) Received: from google.com (161.74.123.34.bc.googleusercontent.com. [34.123.74.161]) by smtp.gmail.com with ESMTPSA id fv5-20020a05663866c500b004741f7683ebsm2243287jab.154.2024.02.21.12.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 12:02:10 -0800 (PST) Date: Wed, 21 Feb 2024 20:02:04 +0000 From: Justin Stitt To: David Gow Cc: Linus Torvalds , Shuah Khan , Guenter Roeck , Rae Moar , Matthew Auld , Arunpravin Paneer Selvam , Christian =?utf-8?B?S8O2bmln?= , Kees Cook , =?utf-8?B?TWHDrXJh?= Canal , Rodrigo Vivi , Matthew Brost , Willem de Bruijn , Florian Westphal , Cassio Neri , Javier Martinez Canillas , Arthur Grillo , Brendan Higgins , Daniel Latypov , Stephen Boyd , David Airlie , Maxime Ripard , "David S . Miller" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 9/9] kunit: Annotate _MSG assertion variants with gnu printf specifiers Message-ID: <20240221200204.frzov7n5bxb4cekd@google.com> References: <20240221092728.1281499-1-davidgow@google.com> <20240221092728.1281499-10-davidgow@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221092728.1281499-10-davidgow@google.com> X-Mailman-Approved-At: Thu, 22 Feb 2024 14:01:23 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi, On Wed, Feb 21, 2024 at 05:27:22PM +0800, David Gow wrote: > KUnit's assertion macros have variants which accept a printf format > string, to allow tests to specify a more detailed message on failure. > These (and the related KUNIT_FAIL() macro) ultimately wrap the > __kunit_do_failed_assertion() function, which accepted a printf format > specifier, but did not have the __printf attribute, so gcc couldn't warn > on incorrect agruments. > > It turns out there were quite a few tests with such incorrect arguments. > > Add the __printf() specifier now that we've fixed these errors, to > prevent them from recurring. > > Suggested-by: Linus Torvalds > Signed-off-by: David Gow Reviewed-by: Justin Stitt > --- > include/kunit/test.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/kunit/test.h b/include/kunit/test.h > index fcb4a4940ace..61637ef32302 100644 > --- a/include/kunit/test.h > +++ b/include/kunit/test.h > @@ -579,12 +579,12 @@ void __printf(2, 3) kunit_log_append(struct string_stream *log, const char *fmt, > > void __noreturn __kunit_abort(struct kunit *test); > > -void __kunit_do_failed_assertion(struct kunit *test, > - const struct kunit_loc *loc, > - enum kunit_assert_type type, > - const struct kunit_assert *assert, > - assert_format_t assert_format, > - const char *fmt, ...); > +void __printf(6, 7) __kunit_do_failed_assertion(struct kunit *test, > + const struct kunit_loc *loc, > + enum kunit_assert_type type, > + const struct kunit_assert *assert, > + assert_format_t assert_format, > + const char *fmt, ...); > > #define _KUNIT_FAILED(test, assert_type, assert_class, assert_format, INITIALIZER, fmt, ...) do { \ > static const struct kunit_loc __loc = KUNIT_CURRENT_LOC; \ > -- > 2.44.0.rc0.258.g7320e95886-goog > Thanks Justin