From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CA82C5479F for ; Thu, 22 Feb 2024 14:01:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E544010E94F; Thu, 22 Feb 2024 14:01:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="oqFmFBi4"; dkim-atps=neutral Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BEF810E809 for ; Wed, 21 Feb 2024 21:06:32 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7c48fc56752so290486539f.3 for ; Wed, 21 Feb 2024 13:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708549592; x=1709154392; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XxARLNt21W5VmobeBOcLL0WanHWe98+J1gabaOyO2/o=; b=oqFmFBi4uVPb9nBclYPij/A1GcvBBe/A6fjtquLm5YU+7JW35GAmo8feMmqNnuPHGI AcFGFjqJjWS492u1zx9XjGKO86Z+0EElDad1T6HajawA1GWj5L+TUAf53fMC/FbcCe8G d8H6KPJs9vDFDw3JMNyWkk8lupI+OcAF3YOOT9qwjs6M8HvOcYRz4rsTb+J9xRLTOEfZ 8lyYrsEZDdMzJsT3rr9+cUdH057V2PaRVlB5/syRZU9UuXabQaDo9jG6KdAXx42DmiHe zmLK1gKsDIEvVre7x6aICKXSEKYh8IOI0q4PN5XBbjOScmZvj6TZRj0Sr5doF38FUh6C 8JBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708549592; x=1709154392; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XxARLNt21W5VmobeBOcLL0WanHWe98+J1gabaOyO2/o=; b=XVV25+PdjHGGM41lOTTx0PKZ/rrWM4k2zqZ6arSb0Ywap053TiKNf0Hz4U6pNNH/hl xIoL9XxRVWjcFdmnW7q+Tb8WzlnYRDh4eSkoFLiJGk8GBV375ke227KtDK+i55XdhYP5 rxFzT1gpYTlsIyMnKEiefdg75S9WZOIiI72kUIQPtvHgTTjFiCo5MOIZgK+UO81vuMmk Cp5dFnlkS8Xw1OznFzEMdVbeJo1K3//pnmqNYKLCpLGXHNiatTHlO+meYu6njQah9mHu u5vqlFHhJMW1x/fWXZTo5gfnuc/KPMtIYF5W87e21AsXmn+FB4CLXEbF745rh2hz1bWe graw== X-Forwarded-Encrypted: i=1; AJvYcCUi2LzgjjYAqC4WSc/fWgYwfXwkQEh1Xf0BK9Ar51qxdFiJOLYGd42fHE+Pn/dYvHyLVWTaL2uQvG/lDQgNuXlVSUC3fbdMgh9haWpm5uw= X-Gm-Message-State: AOJu0YxLyljqJULtOubEMiuF2aATBJ04iKAor/Z/xs6rNGvNoooZtwF+ tPkRfYUOAzcDYMTV0miiuc+wkSV7YI7hquvIAGQtf3AdmM/X5IsykI34Tr+Qgg== X-Google-Smtp-Source: AGHT+IHqbTAIdmbfdrW7leotGJWoTRmx3P/Ksrvh7bnDyBM1dx8JyMMMiikIoom0nj0o+fE8Ko+j0A== X-Received: by 2002:a5d:894e:0:b0:7c3:f542:66d8 with SMTP id b14-20020a5d894e000000b007c3f54266d8mr21472703iot.1.1708549591657; Wed, 21 Feb 2024 13:06:31 -0800 (PST) Received: from google.com (161.74.123.34.bc.googleusercontent.com. [34.123.74.161]) by smtp.gmail.com with ESMTPSA id fv5-20020a05663866c500b004741f7683ebsm2272779jab.154.2024.02.21.13.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 13:06:30 -0800 (PST) Date: Wed, 21 Feb 2024 21:06:28 +0000 From: Justin Stitt To: David Gow Cc: Linus Torvalds , Shuah Khan , Guenter Roeck , Rae Moar , Matthew Auld , Arunpravin Paneer Selvam , Christian =?utf-8?B?S8O2bmln?= , Kees Cook , =?utf-8?B?TWHDrXJh?= Canal , Rodrigo Vivi , Matthew Brost , Willem de Bruijn , Florian Westphal , Cassio Neri , Javier Martinez Canillas , Arthur Grillo , Brendan Higgins , Daniel Latypov , Stephen Boyd , David Airlie , Maxime Ripard , "David S . Miller" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 4/9] time: test: Fix incorrect format specifier Message-ID: <20240221210628.vshmqtyeecemin4k@google.com> References: <20240221092728.1281499-1-davidgow@google.com> <20240221092728.1281499-5-davidgow@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221092728.1281499-5-davidgow@google.com> X-Mailman-Approved-At: Thu, 22 Feb 2024 14:01:23 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi, On Wed, Feb 21, 2024 at 05:27:17PM +0800, David Gow wrote: > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > This was found by extending KUnit's assertion macros to use gcc's > __printf attribute. > > Fixes: 276010551664 ("time: Improve performance of time64_to_tm()") > Signed-off-by: David Gow Reviewed-by: Justin Stitt > --- > kernel/time/time_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c > index ca058c8af6ba..3e5d422dd15c 100644 > --- a/kernel/time/time_test.c > +++ b/kernel/time/time_test.c > @@ -73,7 +73,7 @@ static void time64_to_tm_test_date_range(struct kunit *test) > > days = div_s64(secs, 86400); > > - #define FAIL_MSG "%05ld/%02d/%02d (%2d) : %ld", \ > + #define FAIL_MSG "%05ld/%02d/%02d (%2d) : %lld", \ > year, month, mdday, yday, days > > KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG); > -- > 2.44.0.rc0.258.g7320e95886-goog > Thanks Justin