From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI 2/2] drm/xe: Move vma rebinding to the drm_exec locking loop
Date: Wed, 6 Mar 2024 11:01:33 +0100 [thread overview]
Message-ID: <20240306100133.4962-2-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240306100133.4962-1-thomas.hellstrom@linux.intel.com>
Rebinding might allocate page-table bos, causing evictions.
To support blocking locking during these evictions,
perform the rebinding in the drm_exec locking loop.
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_exec.c | 4 ++++
drivers/gpu/drm/xe/xe_vm.c | 12 +++++++-----
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_exec.c b/drivers/gpu/drm/xe/xe_exec.c
index 5124663a9694..b683ce415ef1 100644
--- a/drivers/gpu/drm/xe/xe_exec.c
+++ b/drivers/gpu/drm/xe/xe_exec.c
@@ -106,6 +106,10 @@ static int xe_exec_fn(struct drm_gpuvm_exec *vm_exec)
if (ret)
return ret;
+ ret = xe_vm_rebind(vm, false);
+ if (ret)
+ return ret;
+
/*
* 1 fence slot for the final submit, and 1 more for every per-tile for
* GPU bind and 1 extra for CPU bind. Note that there are potentially
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 427b2063d876..732132bba537 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -515,7 +515,13 @@ static int xe_preempt_work_begin(struct drm_exec *exec, struct xe_vm *vm,
if (err)
return err;
- return drm_gpuvm_validate(&vm->gpuvm, exec);
+ err = drm_gpuvm_validate(&vm->gpuvm, exec);
+ if (err)
+ return err;
+
+ err = xe_vm_rebind(vm, true);
+
+ return err;
}
static void preempt_rebind_work_func(struct work_struct *w)
@@ -567,10 +573,6 @@ static void preempt_rebind_work_func(struct work_struct *w)
if (err)
goto out_unlock;
- err = xe_vm_rebind(vm, true);
- if (err)
- goto out_unlock;
-
if (vm->rebind_fence) {
dma_fence_wait(vm->rebind_fence, false);
dma_fence_put(vm->rebind_fence);
--
2.44.0
next prev parent reply other threads:[~2024-03-06 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 10:01 [CI 1/2] drm/xe: Rework xe_vm_rebind() Thomas Hellström
2024-03-06 10:01 ` Thomas Hellström [this message]
2024-03-07 4:41 ` [CI 2/2] drm/xe: Move vma rebinding to the drm_exec locking loop Matthew Brost
2024-03-06 10:15 ` ✓ CI.Patch_applied: success for series starting with [CI,1/2] drm/xe: Rework xe_vm_rebind() Patchwork
2024-03-06 10:15 ` ✓ CI.checkpatch: " Patchwork
2024-03-06 10:16 ` ✓ CI.KUnit: " Patchwork
2024-03-06 10:27 ` ✓ CI.Build: " Patchwork
2024-03-06 10:27 ` ✗ CI.Hooks: failure " Patchwork
2024-03-06 10:28 ` ✓ CI.checksparse: success " Patchwork
2024-03-06 11:01 ` ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306100133.4962-2-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).