From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Michal Wajdeczko" <michal.wajdeczko@intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: [PATCH v2 2/3] drm/xe/pf: Request 64K aligned allocations for LMTT PD
Date: Wed, 13 Mar 2024 11:41:31 +0100 [thread overview]
Message-ID: <20240313104132.1045-3-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240313104132.1045-1-michal.wajdeczko@intel.com>
The LMTT Page Directory, as well as the directory entries, must be
aligned on a 64KB boundary in VRAM. Use explicit alignment flag to
match hardware requirement.
Bspec: 52404, 67468
Cc: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_lmtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
index 0d7c5514e092..dfb0e1887615 100644
--- a/drivers/gpu/drm/xe/xe_lmtt.c
+++ b/drivers/gpu/drm/xe/xe_lmtt.c
@@ -71,7 +71,7 @@ static struct xe_lmtt_pt *lmtt_pt_alloc(struct xe_lmtt *lmtt, unsigned int level
lmtt->ops->lmtt_pte_num(level)),
ttm_bo_type_kernel,
XE_BO_CREATE_VRAM_IF_DGFX(lmtt_to_tile(lmtt)) |
- XE_BO_CREATE_PINNED_BIT);
+ XE_BO_NEEDS_64K | XE_BO_CREATE_PINNED_BIT);
if (IS_ERR(bo)) {
err = PTR_ERR(bo);
goto out_free_pt;
--
2.43.0
next prev parent reply other threads:[~2024-03-13 10:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 10:41 [PATCH v2 0/3] LMTT improvements Michal Wajdeczko
2024-03-13 10:41 ` [PATCH v2 1/3] drm/xe: Allow VRAM BO allocations aligned to 64K Michal Wajdeczko
2024-03-13 10:41 ` Michal Wajdeczko [this message]
2024-03-13 10:41 ` [PATCH v2 3/3] drm/xe/pf: Always select Multi-Level LMTT for platforms 12.60+ Michal Wajdeczko
2024-03-14 23:36 ` Rodrigo Vivi
2024-03-13 11:23 ` ✓ CI.Patch_applied: success for LMTT improvements (rev2) Patchwork
2024-03-13 11:24 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-13 11:24 ` ✓ CI.KUnit: success " Patchwork
2024-03-13 11:35 ` ✓ CI.Build: " Patchwork
2024-03-13 11:38 ` ✓ CI.Hooks: " Patchwork
2024-03-13 11:39 ` ✓ CI.checksparse: " Patchwork
2024-03-13 12:17 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313104132.1045-3-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.winiarski@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox