Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Matt Roper" <matthew.d.roper@intel.com>
Subject: [PATCH 1/2] drm/xe: Stop passing user flag to xe_bo_create_user()
Date: Wed, 13 Mar 2024 22:26:18 -0700	[thread overview]
Message-ID: <20240314052619.2628396-2-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240314052619.2628396-1-lucas.demarchi@intel.com>

It's quite redundant to pass XE_BO_CREATE_USER_BIT to
xe_bo_create_user() since the only difference of that function is to
force that flag. Stop passing the flag in the few cases that were
explicitly doing so.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/tests/xe_dma_buf.c | 2 +-
 drivers/gpu/drm/xe/xe_bo.c            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/tests/xe_dma_buf.c b/drivers/gpu/drm/xe/tests/xe_dma_buf.c
index 9f6d571d7fa9..2a86dc4eb8af 100644
--- a/drivers/gpu/drm/xe/tests/xe_dma_buf.c
+++ b/drivers/gpu/drm/xe/tests/xe_dma_buf.c
@@ -125,7 +125,7 @@ static void xe_test_dmabuf_import_same_driver(struct xe_device *xe)
 
 	kunit_info(test, "running %s\n", __func__);
 	bo = xe_bo_create_user(xe, NULL, NULL, size, DRM_XE_GEM_CPU_CACHING_WC,
-			       ttm_bo_type_device, XE_BO_CREATE_USER_BIT | params->mem_mask);
+			       ttm_bo_type_device, params->mem_mask);
 	if (IS_ERR(bo)) {
 		KUNIT_FAIL(test, "xe_bo_create() failed with err=%ld\n",
 			   PTR_ERR(bo));
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index d7e0deb1b869..afb8292af692 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -2276,7 +2276,7 @@ int xe_bo_dumb_create(struct drm_file *file_priv,
 			       DRM_XE_GEM_CPU_CACHING_WC,
 			       ttm_bo_type_device,
 			       XE_BO_CREATE_VRAM_IF_DGFX(xe_device_get_root_tile(xe)) |
-			       XE_BO_CREATE_USER_BIT | XE_BO_SCANOUT_BIT |
+			       XE_BO_SCANOUT_BIT |
 			       XE_BO_NEEDS_CPU_ACCESS);
 	if (IS_ERR(bo))
 		return PTR_ERR(bo);
-- 
2.43.0


  reply	other threads:[~2024-03-14  5:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14  5:26 [PATCH 0/2] drm/xe: Refactor BO flags Lucas De Marchi
2024-03-14  5:26 ` Lucas De Marchi [this message]
2024-03-14 17:07   ` [PATCH 1/2] drm/xe: Stop passing user flag to xe_bo_create_user() Matthew Auld
2024-03-14  5:26 ` [PATCH 2/2] drm/xe: Normalize bo flags macros Lucas De Marchi
2024-03-14 17:19   ` Matthew Auld
2024-03-14  5:32 ` ✓ CI.Patch_applied: success for drm/xe: Refactor BO flags Patchwork
2024-03-14  5:33 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-14  5:33 ` ✓ CI.KUnit: success " Patchwork
2024-03-14  5:45 ` ✓ CI.Build: " Patchwork
2024-03-14  5:47 ` ✓ CI.Hooks: " Patchwork
2024-03-14  5:48 ` ✓ CI.checksparse: " Patchwork
2024-03-14  6:31 ` ✗ CI.BAT: failure " Patchwork
2024-03-14 16:41   ` Lucas De Marchi
2024-03-15  6:38     ` Musial, Ewelina
2024-03-16  0:52       ` Lucas De Marchi
2024-03-14 19:17 ` ✓ CI.Patch_applied: success for drm/xe: Refactor BO flags (rev2) Patchwork
2024-03-14 19:17 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-14 19:18 ` ✓ CI.KUnit: success " Patchwork
2024-03-14 19:30 ` ✓ CI.Build: " Patchwork
2024-03-14 19:33 ` ✓ CI.Hooks: " Patchwork
2024-03-14 19:34 ` ✓ CI.checksparse: " Patchwork
2024-03-14 19:57 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240314052619.2628396-2-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox