Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: [PATCH v2 2/2] drm/xe/client: drop bogus bo NULL check
Date: Mon, 18 Mar 2024 09:34:33 +0000	[thread overview]
Message-ID: <20240318093431.21075-4-matthew.auld@intel.com> (raw)
In-Reply-To: <20240318093431.21075-3-matthew.auld@intel.com>

If we fished it out the list then it can't be null; the list entry is
embedded in the bo.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_drm_client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_drm_client.c b/drivers/gpu/drm/xe/xe_drm_client.c
index 59b01d838229..08f0b7c95901 100644
--- a/drivers/gpu/drm/xe/xe_drm_client.c
+++ b/drivers/gpu/drm/xe/xe_drm_client.c
@@ -155,7 +155,7 @@ static void show_meminfo(struct drm_printer *p, struct drm_file *file)
 	/* Internal objects. */
 	spin_lock(&client->bos_lock);
 	list_for_each_entry(bo, &client->bos_list, client_link) {
-		if (!bo || !kref_get_unless_zero(&bo->ttm.base.refcount))
+		if (!kref_get_unless_zero(&bo->ttm.base.refcount))
 			continue;
 		bo_meminfo(bo, stats);
 		xe_bo_put(bo);
-- 
2.44.0


  reply	other threads:[~2024-03-18  9:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18  9:34 [PATCH v2 1/2] drm/xe/client: remove bogus rcu list usage Matthew Auld
2024-03-18  9:34 ` Matthew Auld [this message]
2024-03-18  9:45   ` [PATCH v2 2/2] drm/xe/client: drop bogus bo NULL check Nirmoy Das
2024-03-18  9:45 ` [PATCH v2 1/2] drm/xe/client: remove bogus rcu list usage Nirmoy Das
2024-03-18 15:58 ` ✓ CI.Patch_applied: success for series starting with [v2,1/2] " Patchwork
2024-03-18 15:58 ` ✓ CI.checkpatch: " Patchwork
2024-03-18 15:59 ` ✓ CI.KUnit: " Patchwork
2024-03-18 16:10 ` ✓ CI.Build: " Patchwork
2024-03-18 16:12 ` ✓ CI.Hooks: " Patchwork
2024-03-18 16:14 ` ✓ CI.checksparse: " Patchwork
2024-03-18 16:35 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240318093431.21075-4-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox