Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH v2 2/2] drm/xe: Add a WARN_ON for NULL job in xe_sync_entry_signal
Date: Mon, 18 Mar 2024 17:43:42 +0100	[thread overview]
Message-ID: <20240318164342.3094-2-nirmoy.das@intel.com> (raw)
In-Reply-To: <20240318164342.3094-1-nirmoy.das@intel.com>

Add a warn for NULL job when sync->type is
DRM_XE_SYNC_TYPE_USER_FENCE. This should be a programming
error and should never happen so warn and let the kernel crash
if that ever happens.

Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_sync.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
index 02c9577fe418..247505c3478d 100644
--- a/drivers/gpu/drm/xe/xe_sync.c
+++ b/drivers/gpu/drm/xe/xe_sync.c
@@ -255,6 +255,7 @@ void xe_sync_entry_signal(struct xe_sync_entry *sync, struct xe_sched_job *job,
 			dma_fence_put(fence);
 		}
 	} else if (sync->type == DRM_XE_SYNC_TYPE_USER_FENCE) {
+		XE_WARN_ON(!job);
 		job->user_fence.used = true;
 		job->user_fence.addr = sync->addr;
 		job->user_fence.value = sync->timeline_value;
-- 
2.42.0


  reply	other threads:[~2024-03-18 16:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 16:43 [PATCH v2 1/2] drm/xe: Fix potential integer overflow in page size calculation Nirmoy Das
2024-03-18 16:43 ` Nirmoy Das [this message]
2024-03-18 17:03   ` [PATCH v2 2/2] drm/xe: Add a WARN_ON for NULL job in xe_sync_entry_signal Matthew Brost
2024-03-18 17:41   ` Michal Wajdeczko
2024-03-18 18:41     ` Nirmoy Das
2024-03-20  3:20       ` Lucas De Marchi
2024-03-20 13:07         ` Nirmoy Das
2025-02-10 18:05   ` Upadhyay, Tejas
2025-02-10 18:14     ` Upadhyay, Tejas
2024-03-18 22:50 ` ✓ CI.Patch_applied: success for series starting with [v2,1/2] drm/xe: Fix potential integer overflow in page size calculation Patchwork
2024-03-18 22:50 ` ✓ CI.checkpatch: " Patchwork
2024-03-18 22:51 ` ✓ CI.KUnit: " Patchwork
2024-03-18 23:01 ` ✓ CI.Build: " Patchwork
2024-03-18 23:04 ` ✓ CI.Hooks: " Patchwork
2024-03-18 23:05 ` ✓ CI.checksparse: " Patchwork
2024-03-18 23:27 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240318164342.3094-2-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox