Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>,
	Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v3 1/2] drm/xe/query: Define and use a constant for the number of masks
Date: Thu, 21 Mar 2024 14:21:53 +0000	[thread overview]
Message-ID: <20240321142154.7-1-francois.dugast@intel.com> (raw)

Replace a magic value by a constant with an explicit name to make clear
what it stands for: the number of masks returned by the topology query.

Suggested-by: Zhanjun Dong <zhanjun.dong@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
 drivers/gpu/drm/xe/xe_query.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
index e80321b34918..fa8de1a77b1e 100644
--- a/drivers/gpu/drm/xe/xe_query.c
+++ b/drivers/gpu/drm/xe/xe_query.c
@@ -23,6 +23,8 @@
 #include "xe_mmio.h"
 #include "xe_ttm_vram_mgr.h"
 
+#define TOPO_NUMBER_OF_MASKS   (3)
+
 static const u16 xe_to_user_engine_class[] = {
 	[XE_ENGINE_CLASS_RENDER] = DRM_XE_ENGINE_CLASS_RENDER,
 	[XE_ENGINE_CLASS_COPY] = DRM_XE_ENGINE_CLASS_COPY,
@@ -453,7 +455,8 @@ static int query_hwconfig(struct xe_device *xe,
 static size_t calc_topo_query_size(struct xe_device *xe)
 {
 	return xe->info.gt_count *
-		(3 * sizeof(struct drm_xe_query_topology_mask) +
+		(TOPO_NUMBER_OF_MASKS
+		 * sizeof(struct drm_xe_query_topology_mask) +
 		 sizeof_field(struct xe_gt, fuse_topo.g_dss_mask) +
 		 sizeof_field(struct xe_gt, fuse_topo.c_dss_mask) +
 		 sizeof_field(struct xe_gt, fuse_topo.eu_mask_per_dss));
-- 
2.34.1


             reply	other threads:[~2024-03-21 14:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 14:21 Francois Dugast [this message]
2024-03-21 14:21 ` [PATCH v3 2/2] drm/xe/uapi: Add L3 bank mask to topology query Francois Dugast
2024-03-21 14:28   ` Francois Dugast
2024-03-21 14:39 ` ✓ CI.Patch_applied: success for series starting with [v3,1/2] drm/xe/query: Define and use a constant for the number of masks Patchwork
2024-03-21 14:39 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-21 14:40 ` ✓ CI.KUnit: success " Patchwork
2024-03-21 14:51 ` ✓ CI.Build: " Patchwork
2024-03-21 14:56 ` ✗ CI.Hooks: failure " Patchwork
2024-03-21 14:57 ` ✓ CI.checksparse: success " Patchwork
2024-03-21 15:24 ` ✗ CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240321142154.7-1-francois.dugast@intel.com \
    --to=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=zhanjun.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox