Re: [PATCH] drm/xe/xe2: Add workaround 18034896535

[Matt Roper <matthew.d.roper@intel.com>]

On Tue, Apr 02, 2024 at 11:41:29AM +0530, Bommu Krishnaiah wrote:
> Add 18034896535 as driver permanent workarounds.
> Also reverting temporary workaround 16021540221.

Why are we reverting 16021540221?  It's still listed in the workaround
database and I don't think we're at the point where we want to remove
preproduction-only workarounds (in fact I don't think we even know yet
exactly which steppings are considered preproduction).

Even when multiple independent workarounds happen to have the same
implementation, we still implement them all in the driver.  The
independent workarounds may extend to future steppings and/or platforms
in different ways and need separate handling.


Matt

> 
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_wa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 74b33a3845f2..4d8e0d64cf42 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -423,8 +423,8 @@ static const struct xe_rtp_entry_sr engine_was[] = {
>  		       FUNC(xe_rtp_match_first_render_or_compute)),
>  	  XE_RTP_ACTIONS(SET(HALF_SLICE_CHICKEN5, DISABLE_SAMPLE_G_PERFORMANCE))
>  	},
> -	{ XE_RTP_NAME("16021540221"),
> -	  XE_RTP_RULES(GRAPHICS_VERSION(2004), GRAPHICS_STEP(A0, B0),
> +	{ XE_RTP_NAME("18034896535"),
> +	  XE_RTP_RULES(GRAPHICS_VERSION(2004),
>  		       FUNC(xe_rtp_match_first_render_or_compute)),
>  	  XE_RTP_ACTIONS(SET(ROW_CHICKEN4, DISABLE_TDL_PUSH))
>  	},
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation