Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 1/3] drm/xe/vf: Don't emit access to Global HWSP if VF
Date: Fri,  5 Apr 2024 15:39:34 +0200	[thread overview]
Message-ID: <20240405133936.891-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240405133936.891-1-michal.wajdeczko@intel.com>

VFs can't access Global HWSP, don't emit questionable MI_FLUSH_DW
while processing a migration job.

Bspec: 52398
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/xe_ring_ops.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
index 5b2b37b59813..d42b3f33bd7a 100644
--- a/drivers/gpu/drm/xe/xe_ring_ops.c
+++ b/drivers/gpu/drm/xe/xe_ring_ops.c
@@ -17,6 +17,7 @@
 #include "xe_lrc.h"
 #include "xe_macros.h"
 #include "xe_sched_job.h"
+#include "xe_sriov.h"
 #include "xe_vm_types.h"
 #include "xe_vm.h"
 #include "xe_wa.h"
@@ -367,10 +368,12 @@ static void emit_migration_job_gen12(struct xe_sched_job *job,
 
 	i = emit_bb_start(job->batch_addr[0], BIT(8), dw, i);
 
-	/* XXX: Do we need this? Leaving for now. */
-	dw[i++] = preparser_disable(true);
-	i = emit_flush_invalidate(0, dw, i);
-	dw[i++] = preparser_disable(false);
+	if (!IS_SRIOV_VF(gt_to_xe(job->q->gt))) {
+		/* XXX: Do we need this? Leaving for now. */
+		dw[i++] = preparser_disable(true);
+		i = emit_flush_invalidate(0, dw, i);
+		dw[i++] = preparser_disable(false);
+	}
 
 	i = emit_bb_start(job->batch_addr[1], BIT(8), dw, i);
 
-- 
2.43.0


  reply	other threads:[~2024-04-05 13:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 13:39 [PATCH 0/3] More VF tweaks Michal Wajdeczko
2024-04-05 13:39 ` Michal Wajdeczko [this message]
2024-04-08 11:19   ` [PATCH 1/3] drm/xe/vf: Don't emit access to Global HWSP if VF Piotr Piórkowski
2024-04-05 13:39 ` [PATCH 2/3] drm/xe/vf: Don't try to program MOCS " Michal Wajdeczko
2024-04-08  6:02   ` Ghimiray, Himal Prasad
2024-04-05 13:39 ` [PATCH 3/3] drm/xe/vf: Don't try to read legacy GuC MMIO notification " Michal Wajdeczko
2024-04-08  6:03   ` Ghimiray, Himal Prasad
2024-04-05 16:09 ` ✓ CI.Patch_applied: success for More VF tweaks Patchwork
2024-04-05 16:10 ` ✓ CI.checkpatch: " Patchwork
2024-04-05 16:12 ` ✓ CI.KUnit: " Patchwork
2024-04-05 16:24 ` ✓ CI.Build: " Patchwork
2024-04-05 16:27 ` ✓ CI.Hooks: " Patchwork
2024-04-05 16:29 ` ✓ CI.checksparse: " Patchwork
2024-04-05 17:06 ` ✓ CI.BAT: " Patchwork
2024-04-08 12:32   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405133936.891-2-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox