Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: [PATCH 08/10] drm/i915: Drop the irqs_disabled() check
Date: Fri,  5 Apr 2024 16:18:26 +0200	[thread overview]
Message-ID: <20240405142737.920626-9-bigeasy@linutronix.de> (raw)
In-Reply-To: <20240405142737.920626-1-bigeasy@linutronix.de>

The !irqs_disabled() check triggers on PREEMPT_RT even with
i915_sched_engine::lock acquired. The reason is the lock is transformed
into a sleeping lock on PREEMPT_RT and does not disable interrupts.

There is no need to check for disabled interrupts. The lockdep
annotation below already check if the lock has been acquired by the
caller and will yell if the interrupts are not disabled.

Remove the !irqs_disabled() check.

Reported-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/gpu/drm/i915/i915_request.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 519e096c607cd..466b5ee8ed6d2 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -608,7 +608,6 @@ bool __i915_request_submit(struct i915_request *request)
 
 	RQ_TRACE(request, "\n");
 
-	GEM_BUG_ON(!irqs_disabled());
 	lockdep_assert_held(&engine->sched_engine->lock);
 
 	/*
@@ -717,7 +716,6 @@ void __i915_request_unsubmit(struct i915_request *request)
 	 */
 	RQ_TRACE(request, "\n");
 
-	GEM_BUG_ON(!irqs_disabled());
 	lockdep_assert_held(&engine->sched_engine->lock);
 
 	/*
-- 
2.43.0


  parent reply	other threads:[~2024-04-05 14:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 14:18 [PATCH 00/10] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-04-05 14:18 ` [PATCH 01/10] drm/i915: Use preempt_disable/enable_rt() where recommended Sebastian Andrzej Siewior
2024-04-05 14:18 ` [PATCH 02/10] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates Sebastian Andrzej Siewior
2024-04-05 14:18 ` [PATCH 03/10] drm/i915: Don't check for atomic context on PREEMPT_RT Sebastian Andrzej Siewior
2024-04-05 14:18 ` [PATCH 04/10] drm/i915: Disable tracing points " Sebastian Andrzej Siewior
2024-04-05 14:18 ` [PATCH 05/10] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE Sebastian Andrzej Siewior
2024-04-08 17:06   ` Steven Rostedt
2024-04-09 11:06     ` Sebastian Andrzej Siewior
2024-04-09 15:55       ` Steven Rostedt
2024-04-10 11:08         ` Sebastian Andrzej Siewior
2024-04-10 14:09           ` Steven Rostedt
2024-04-05 14:18 ` [PATCH 06/10] drm/i915/gt: Queue and wait for the irq_work item Sebastian Andrzej Siewior
2024-04-05 14:18 ` [PATCH 07/10] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Sebastian Andrzej Siewior
2024-04-05 14:18 ` Sebastian Andrzej Siewior [this message]
2024-04-05 14:18 ` [PATCH 09/10] drm/i915/guc: Consider also RCU depth in busy loop Sebastian Andrzej Siewior
2024-06-11 22:18   ` Rodrigo Vivi
2024-04-05 14:18 ` [PATCH 10/10] Revert "drm/i915: Depend on !PREEMPT_RT." Sebastian Andrzej Siewior
2024-04-05 17:16 ` ✗ CI.Patch_applied: failure for drm/i915: PREEMPT_RT related fixups Patchwork
2024-04-10 11:58 ` ✗ CI.Patch_applied: failure for drm/i915: PREEMPT_RT related fixups. (rev2) Patchwork
2024-06-05 10:01 ` [PATCH 00/10] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-06-11 13:06   ` Tvrtko Ursulin
2024-06-11 15:14     ` Sebastian Andrzej Siewior
2024-06-11 22:25       ` Rodrigo Vivi
2024-06-13  8:36         ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405142737.920626-9-bigeasy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox