Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, lucas.demarchi@intel.com
Subject: [PATCH 2/2] drm/xe/display: remove compat raw reg read/write support
Date: Mon,  8 Apr 2024 15:54:45 +0300	[thread overview]
Message-ID: <20240408125445.3227678-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20240408125445.3227678-1-jani.nikula@intel.com>

The i915 display code no longer uses these interfaces. Remove them.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 .../drm/xe/compat-i915-headers/intel_uncore.h | 24 -------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h
index ef79793caa72..a672165ececf 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h
@@ -148,28 +148,4 @@ static inline void intel_uncore_write_notrace(struct intel_uncore *uncore,
 	xe_mmio_write32(__compat_uncore_to_gt(uncore), reg, val);
 }
 
-static inline void __iomem *intel_uncore_regs(struct intel_uncore *uncore)
-{
-	struct xe_device *xe = container_of(uncore, struct xe_device, uncore);
-
-	return xe_device_get_root_tile(xe)->mmio.regs;
-}
-
-/*
- * The raw_reg_{read,write} macros are intended as a micro-optimization for
- * interrupt handlers so that the pointer indirection on uncore->regs can
- * be computed once (and presumably cached in a register) instead of generating
- * extra load instructions for each MMIO access.
- *
- * Given that these macros are only intended for non-GSI interrupt registers
- * (and the goal is to avoid extra instructions generated by the compiler),
- * these macros do not account for uncore->gsi_offset.  Any caller that needs
- * to use these macros on a GSI register is responsible for adding the
- * appropriate GSI offset to the 'base' parameter.
- */
-#define raw_reg_read(base, reg) \
-	readl(base + i915_mmio_reg_offset(reg))
-#define raw_reg_write(base, reg, value) \
-	writel(value, base + i915_mmio_reg_offset(reg))
-
 #endif /* __INTEL_UNCORE_H__ */
-- 
2.39.2


  reply	other threads:[~2024-04-08 12:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 12:54 [PATCH 1/2] drm/i915/display: remove small micro-optimizations in irq handling Jani Nikula
2024-04-08 12:54 ` Jani Nikula [this message]
2024-04-17 20:47   ` [PATCH 2/2] drm/xe/display: remove compat raw reg read/write support Sripada, Radhakrishna
2024-04-08 15:08 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/i915/display: remove small micro-optimizations in irq handling Patchwork
2024-04-08 15:08 ` ✓ CI.checkpatch: " Patchwork
2024-04-08 15:10 ` ✓ CI.KUnit: " Patchwork
2024-04-08 15:22 ` ✓ CI.Build: " Patchwork
2024-04-08 15:24 ` ✓ CI.Hooks: " Patchwork
2024-04-08 15:26 ` ✗ CI.checksparse: warning " Patchwork
2024-04-08 15:52 ` ✓ CI.BAT: success " Patchwork
2024-04-08 17:52 ` ✓ CI.FULL: " Patchwork
2024-04-17 20:42 ` [PATCH 1/2] " Sripada, Radhakrishna
2024-04-17 21:44 ` Lucas De Marchi
2024-04-18  9:49   ` Jani Nikula
2024-04-18 10:57     ` Tvrtko Ursulin
2024-09-17 10:58       ` Jani Nikula
2024-09-17 14:02         ` Rodrigo Vivi
2024-09-17 14:48           ` Ville Syrjälä
2024-09-19 13:14             ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408125445.3227678-2-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox