From: Thomas Zimmermann <tzimmermann@suse.de>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, ville.syrjala@linux.intel.com,
imre.deak@intel.com, tejas.upadhyay@intel.com,
jouni.hogander@intel.com, javierm@redhat.com, airlied@gmail.com,
daniel@ffwll.ch, lucas.demarchi@intel.com, ogabbay@kernel.org,
thomas.hellstrom@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v8 4/6] drm/{i915,xe}: Unregister in-kernel clients
Date: Tue, 9 Apr 2024 10:04:26 +0200 [thread overview]
Message-ID: <20240409081029.17843-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20240409081029.17843-1-tzimmermann@suse.de>
Unregister all in-kernel clients before unloading the i915 driver. For
other drivers, drm_dev_unregister() does this automatically. As i915 and
xe do not use this helper, they have to perform the call by themselves.
Note that there are currently no in-kernel clients in i915 or xe. The
patch prepares the drivers for a related update of their fbdev support.
v8:
- unregister clients in intel_display_driver_unregister() (Jani)
- mention xe in commit message (Rodrigo, Jani)
v7:
- update xe driver
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 3 +++
drivers/gpu/drm/xe/xe_device.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
index 87dd07e0d138d..b7d636980d83a 100644
--- a/drivers/gpu/drm/i915/display/intel_display_driver.c
+++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
@@ -11,6 +11,7 @@
#include <acpi/video.h>
#include <drm/display/drm_dp_mst_helper.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_client.h>
#include <drm/drm_mode_config.h>
#include <drm/drm_privacy_screen_consumer.h>
#include <drm/drm_probe_helper.h>
@@ -638,6 +639,8 @@ void intel_display_driver_unregister(struct drm_i915_private *i915)
if (!HAS_DISPLAY(i915))
return;
+ drm_client_dev_unregister(&i915->drm);
+
intel_fbdev_unregister(i915);
/*
* After flushing the fbdev (incl. a late async config which
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 01bd5ccf05ca6..231ab2f4cd0b9 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -9,6 +9,7 @@
#include <drm/drm_aperture.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_client.h>
#include <drm/drm_gem_ttm_helper.h>
#include <drm/drm_ioctl.h>
#include <drm/drm_managed.h>
--
2.44.0
next prev parent reply other threads:[~2024-04-09 8:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 8:04 [PATCH v8 0/6] drm/{i915,xe}: Convert fbdev to DRM client Thomas Zimmermann
2024-04-09 8:04 ` [PATCH v8 1/6] drm/client: Export drm_client_dev_unregister() Thomas Zimmermann
2024-04-22 14:09 ` Hogander, Jouni
2024-04-09 8:04 ` [PATCH v8 2/6] drm/i915: Move fbdev functions Thomas Zimmermann
2024-04-09 8:04 ` [PATCH v8 3/6] drm/i915: Initialize fbdev DRM client with callback functions Thomas Zimmermann
2024-04-09 8:04 ` Thomas Zimmermann [this message]
2024-04-22 14:10 ` [PATCH v8 4/6] drm/{i915,xe}: Unregister in-kernel clients Hogander, Jouni
2024-04-09 8:04 ` [PATCH v8 5/6] drm/{i915,xe}: Implement fbdev client callbacks Thomas Zimmermann
2024-04-09 8:04 ` [PATCH v8 6/6] drm/{i915, xe}: Implement fbdev emulation as in-kernel client Thomas Zimmermann
2024-04-22 14:11 ` [PATCH v8 6/6] drm/{i915,xe}: " Hogander, Jouni
2024-04-23 11:13 ` Thomas Zimmermann
2024-04-23 11:36 ` Hogander, Jouni
2024-04-23 13:09 ` Thomas Zimmermann
2024-04-25 11:51 ` Jani Nikula
2024-04-23 13:49 ` Jani Nikula
2024-04-09 8:15 ` ✓ CI.Patch_applied: success for drm/{i915,xe}: Convert fbdev to DRM client Patchwork
2024-04-09 8:16 ` ✓ CI.checkpatch: " Patchwork
2024-04-09 8:17 ` ✓ CI.KUnit: " Patchwork
2024-04-09 8:28 ` ✓ CI.Build: " Patchwork
2024-04-09 8:31 ` ✓ CI.Hooks: " Patchwork
2024-04-09 8:32 ` ✗ CI.checksparse: warning " Patchwork
2024-04-09 8:53 ` ✓ CI.BAT: success " Patchwork
2024-04-09 10:03 ` ✗ CI.FULL: failure " Patchwork
2024-04-24 20:29 ` [PATCH v8 0/6] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409081029.17843-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jouni.hogander@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=ogabbay@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tejas.upadhyay@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox