From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH 2/2] drm/xe: Check pat.ops before dumping PAT settings
Date: Tue, 9 Apr 2024 12:51:06 +0200 [thread overview]
Message-ID: <20240409105106.1067-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240409105106.1067-1-michal.wajdeczko@intel.com>
We may leave pat.ops unset when running on brand new platform or
when running as a VF. While the former is unlikely, the latter
is valid (future) use case and will cause NPD when someone will
try to dump PAT settings by debugfs.
It's better to check pointer to pat.ops instead of specific .dump
hook, as we have this hook always defined for every .ops variant.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_pat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
index 026e4a9fe124..4118c3084398 100644
--- a/drivers/gpu/drm/xe/xe_pat.c
+++ b/drivers/gpu/drm/xe/xe_pat.c
@@ -451,7 +451,7 @@ void xe_pat_dump(struct xe_gt *gt, struct drm_printer *p)
{
struct xe_device *xe = gt_to_xe(gt);
- if (!xe->pat.ops->dump)
+ if (!xe->pat.ops)
return;
xe->pat.ops->dump(gt, p);
--
2.43.0
next prev parent reply other threads:[~2024-04-09 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 10:51 [PATCH 1/2] drm/xe: Assert pat.ops function pointers Michal Wajdeczko
2024-04-09 10:51 ` Michal Wajdeczko [this message]
2024-04-09 13:09 ` [PATCH 2/2] drm/xe: Check pat.ops before dumping PAT settings Piotr Piórkowski
2024-04-09 10:56 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Assert pat.ops function pointers Patchwork
2024-04-09 10:57 ` ✓ CI.checkpatch: " Patchwork
2024-04-09 10:58 ` ✓ CI.KUnit: " Patchwork
2024-04-09 11:10 ` ✓ CI.Build: " Patchwork
2024-04-09 11:12 ` ✓ CI.Hooks: " Patchwork
2024-04-09 11:14 ` ✓ CI.checksparse: " Patchwork
2024-04-09 11:37 ` ✓ CI.BAT: " Patchwork
2024-04-09 12:48 ` ✗ CI.FULL: failure " Patchwork
2024-04-09 16:30 ` Michal Wajdeczko
2024-04-09 13:09 ` [PATCH 1/2] " Piotr Piórkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409105106.1067-2-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox