From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH] drm/xe: Check result of drmm_mutex_init()
Date: Tue, 9 Apr 2024 17:31:32 +0200 [thread overview]
Message-ID: <20240409153132.1111-1-michal.wajdeczko@intel.com> (raw)
Although it's unlikely that drmm_mutex_init() will fail during
driver initialization, however we shouldn't ignore this case.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 9083f5e02dd9..ba3643906d9e 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -273,7 +273,9 @@ struct xe_device *xe_device_create(struct pci_dev *pdev,
init_waitqueue_head(&xe->ufence_wq);
- drmm_mutex_init(&xe->drm, &xe->usm.lock);
+ err = drmm_mutex_init(&xe->drm, &xe->usm.lock);
+ if (err)
+ goto err;
xa_init_flags(&xe->usm.asid_to_vm, XA_FLAGS_ALLOC);
if (IS_ENABLED(CONFIG_DRM_XE_DEBUG)) {
--
2.43.0
next reply other threads:[~2024-04-09 15:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 15:31 Michal Wajdeczko [this message]
2024-04-09 15:37 ` [PATCH] drm/xe: Check result of drmm_mutex_init() Ghimiray, Himal Prasad
2024-04-09 15:39 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-09 15:39 ` ✓ CI.checkpatch: " Patchwork
2024-04-09 15:40 ` ✓ CI.KUnit: " Patchwork
2024-04-09 15:52 ` ✓ CI.Build: " Patchwork
2024-04-09 15:56 ` ✓ CI.Hooks: " Patchwork
2024-04-09 15:58 ` ✓ CI.checksparse: " Patchwork
2024-04-09 16:20 ` ✓ CI.BAT: " Patchwork
2024-04-09 17:22 ` ✗ CI.FULL: failure " Patchwork
2024-04-09 18:01 ` [PATCH] " Lucas De Marchi
2024-04-10 4:28 ` Ghimiray, Himal Prasad
2024-04-10 13:50 ` Lucas De Marchi
2024-04-24 22:38 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409153132.1111-1-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox