From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Matt Roper <matthew.d.roper@intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: [PATCH 2/2] drm/xe/stolen: ignore first page for FBC
Date: Fri, 12 Apr 2024 16:03:03 +0100 [thread overview]
Message-ID: <20240412150301.273344-4-matthew.auld@intel.com> (raw)
In-Reply-To: <20240412150301.273344-3-matthew.auld@intel.com>
We have observed underruns on some platforms if the CFB offset is within
the first page of stolen. Just like i915 skip the first page.
v2 (Maarten)
- Also align the start.
BSpec: 50214
Reported-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
| 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--git a/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
index b4ccc4231e7d..cb6c7598824b 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
@@ -19,8 +19,13 @@ static inline int i915_gem_stolen_insert_node_in_range(struct xe_device *xe,
int err;
u32 flags = XE_BO_FLAG_PINNED | XE_BO_FLAG_STOLEN;
- if (align)
+ if (start < SZ_4K)
+ start = SZ_4K;
+
+ if (align) {
size = ALIGN(size, align);
+ start = ALIGN(start, align);
+ }
bo = xe_bo_create_locked_range(xe, xe_device_get_root_tile(xe),
NULL, size, start, end,
--
2.44.0
next prev parent reply other threads:[~2024-04-12 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 15:03 [PATCH 1/2] drm/xe/stolen: lower the default alignment Matthew Auld
2024-04-12 15:03 ` Matthew Auld [this message]
2024-05-01 12:37 ` [PATCH 2/2] drm/xe/stolen: ignore first page for FBC Saarinen, Jani
2024-04-15 14:04 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/stolen: lower the default alignment Patchwork
2024-04-15 14:05 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-15 14:05 ` ✓ CI.KUnit: success " Patchwork
2024-04-15 14:17 ` ✓ CI.Build: " Patchwork
2024-04-15 14:19 ` ✓ CI.Hooks: " Patchwork
2024-04-15 14:21 ` ✓ CI.checksparse: " Patchwork
2024-04-15 14:44 ` ✓ CI.BAT: " Patchwork
2024-04-15 19:42 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412150301.273344-4-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox