Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Piotr Piórkowski" <piotr.piorkowski@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/guc: Fix typos in VF CFG KLVs descriptions
Date: Wed, 24 Apr 2024 21:00:05 +0200	[thread overview]
Message-ID: <20240424190005.eavg5mlvhwgwa77m@intel.com> (raw)
In-Reply-To: <20240424140506.2133-1-michal.wajdeczko@intel.com>

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on śro [2024-kwi-24 16:05:06 +0200]:
> Apart from the obvious spelling typo, use the correct values for
> infinity quantum/timeout settings (it's 0x0 instead of 0xFFFFFFFF).
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
> ---
>  drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/abi/guc_klvs_abi.h b/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
> index e53ffaee2fcd..5c1d40432ca0 100644
> --- a/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
> +++ b/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
> @@ -194,9 +194,9 @@ enum  {
>   *      granularity) since the GPUs clock time runs off a different crystal
>   *      from the CPUs clock. Changing this KLV on a VF that is currently
>   *      running a context wont take effect until a new context is scheduled in.
> - *      That said, when the PF is changing this value from 0xFFFFFFFF to
> - *      something else, it might never take effect if the VF is running an
> - *      inifinitely long compute or shader kernel. In such a scenario, the
> + *      That said, when the PF is changing this value from 0x0 to
> + *      a non-zero value, it might never take effect if the VF is running an
> + *      infinitely long compute or shader kernel. In such a scenario, the
>   *      PF would need to trigger a VM PAUSE and then change the KLV to force
>   *      it to take effect. Such cases might typically happen on a 1PF+1VF
>   *      Virtualization config enabled for heavier workloads like AI/ML.
> @@ -215,9 +215,9 @@ enum  {
>   *      different crystal from the CPUs clock. Changing this KLV on a VF
>   *      that is currently running a context wont take effect until a new
>   *      context is scheduled in.
> - *      That said, when the PF is changing this value from 0xFFFFFFFF to
> - *      something else, it might never take effect if the VF is running an
> - *      inifinitely long compute or shader kernel.
> + *      That said, when the PF is changing this value from 0x0 to
> + *      a non-zero value, it might never take effect if the VF is running an
> + *      infinitely long compute or shader kernel.
>   *      In this case, the PF would need to trigger a VM PAUSE and then change
>   *      the KLV to force it to take effect. Such cases might typically happen
>   *      on a 1PF+1VF Virtualization config enabled for heavier workloads like

Acked-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> -- 
> 2.43.0
> 

-- 

  parent reply	other threads:[~2024-04-24 19:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 14:05 [PATCH] drm/xe/guc: Fix typos in VF CFG KLVs descriptions Michal Wajdeczko
2024-04-24 16:20 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-24 16:20 ` ✓ CI.checkpatch: " Patchwork
2024-04-24 16:21 ` ✓ CI.KUnit: " Patchwork
2024-04-24 16:33 ` ✓ CI.Build: " Patchwork
2024-04-24 16:35 ` ✓ CI.Hooks: " Patchwork
2024-04-24 16:37 ` ✓ CI.checksparse: " Patchwork
2024-04-24 17:20 ` ✓ CI.BAT: " Patchwork
2024-04-24 19:00 ` Piotr Piórkowski [this message]
2024-04-25 14:21   ` [PATCH] " Piotr Piórkowski
2024-04-25  9:40 ` ✓ CI.FULL: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424190005.eavg5mlvhwgwa77m@intel.com \
    --to=piotr.piorkowski@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox