Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH 1/2] drm/xe/uc: Reorder post hwconfig uC initialization step
Date: Fri, 10 May 2024 22:38:09 +0200	[thread overview]
Message-ID: <20240510203810.1952-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240510203810.1952-1-michal.wajdeczko@intel.com>

We want to move the GuC submission initialization to the post
hwconfig step, but now this step is done too late as migration
initialization uses exec_queue that would crash due to a unset
exec_queue_ops. We can easily fix that by small function reorder.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_gt.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index 36c7b1631fa6..644bccc9bf4e 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -434,6 +434,10 @@ static int all_fw_domain_init(struct xe_gt *gt)
 	if (err)
 		goto err_force_wake;
 
+	err = xe_uc_init_post_hwconfig(&gt->uc);
+	if (err)
+		goto err_force_wake;
+
 	if (!xe_gt_is_media_type(gt)) {
 		/*
 		 * USM has its only SA pool to non-block behind user operations
@@ -460,10 +464,6 @@ static int all_fw_domain_init(struct xe_gt *gt)
 		}
 	}
 
-	err = xe_uc_init_post_hwconfig(&gt->uc);
-	if (err)
-		goto err_force_wake;
-
 	err = xe_uc_init_hw(&gt->uc);
 	if (err)
 		goto err_force_wake;
-- 
2.43.0


  reply	other threads:[~2024-05-10 20:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 20:38 [PATCH 0/2] Move GuC submission init to post hwconfig step Michal Wajdeczko
2024-05-10 20:38 ` Michal Wajdeczko [this message]
2024-05-14 20:23   ` [PATCH 1/2] drm/xe/uc: Reorder post hwconfig uC initialization step Matthew Brost
2024-05-10 20:38 ` [PATCH 2/2] drm/xe/uc: Move GuC submission init to post hwconfig step Michal Wajdeczko
2024-05-14 20:24   ` Matthew Brost
2024-05-10 21:03 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-10 21:03 ` ✓ CI.checkpatch: " Patchwork
2024-05-10 21:04 ` ✓ CI.KUnit: " Patchwork
2024-05-10 21:16 ` ✓ CI.Build: " Patchwork
2024-05-10 21:19 ` ✓ CI.Hooks: " Patchwork
2024-05-10 21:20 ` ✓ CI.checksparse: " Patchwork
2024-05-10 21:41 ` ✓ CI.BAT: " Patchwork
2024-05-11  1:02 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510203810.1952-2-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox