Re: [PATCH 8/8] drm/xe/pf: Expose PF monitor details via debugfs

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on pon [2024-maj-06 15:38:14 +0200]:
> For debug purposes we might want to view statistics maintained by
> the PF driver about VFs activity.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c
> index eb71c2009c34..2290ddaf9594 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c
> @@ -17,6 +17,7 @@
>  #include "xe_gt_sriov_pf_control.h"
>  #include "xe_gt_sriov_pf_debugfs.h"
>  #include "xe_gt_sriov_pf_helpers.h"
> +#include "xe_gt_sriov_pf_monitor.h"
>  #include "xe_gt_sriov_pf_policy.h"
>  #include "xe_gt_sriov_pf_service.h"
>  #include "xe_pm.h"
> @@ -55,6 +56,7 @@ static unsigned int extract_vfid(struct dentry *d)
>   *      │   │   ├── doorbells_provisioned
>   *      │   │   ├── runtime_registers
>   *      │   │   ├── negotiated_versions
> + *      │   │   ├── adverse_events
>   */
>  
>  static const struct drm_info_list pf_info[] = {
> @@ -88,6 +90,11 @@ static const struct drm_info_list pf_info[] = {
>  		.show = xe_gt_debugfs_simple_show,
>  		.data = xe_gt_sriov_pf_service_print_version,
>  	},
> +	{
> +		"adverse_events",
> +		.show = xe_gt_debugfs_simple_show,
> +		.data = xe_gt_sriov_pf_monitor_print_events,
> +	},
>  };


LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

>  
>  /*
> -- 
> 2.43.0
> 

--