Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI v3 12/21] dma-buf/dma-resv: Introduce dma_resv_trylock_ctx()
Date: Thu, 16 May 2024 20:23:30 +0200	[thread overview]
Message-ID: <20240516182339.3482-13-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240516182339.3482-1-thomas.hellstrom@linux.intel.com>

For the drm_exec_trylock() functionality, there is a need to be able
to trylock a dma-resv object as part of a drm_exec transaction.
Therefore expose a variant of dma_resv_trylock that also takes
a struct ww_acquire_ctx parameter.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 include/linux/dma-resv.h | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h
index 8d0e34dad446..68dae8f2a22c 100644
--- a/include/linux/dma-resv.h
+++ b/include/linux/dma-resv.h
@@ -405,6 +405,27 @@ static inline int dma_resv_lock_slow_interruptible(struct dma_resv *obj,
 	return ww_mutex_lock_slow_interruptible(&obj->lock, ctx);
 }
 
+/**
+ * dma_resv_trylock_ctx - trylock the reservation object
+ * @obj: the reservation object
+ * @ctx: The ww acquire context or NULL.
+ *
+ * Tries to lock the reservation object for exclusive access and modification.
+ * Note, that the lock is only against other writers, readers will run
+ * concurrently with a writer under RCU. The seqlock is used to notify readers
+ * if they overlap with a writer. The context parameter ensures that other
+ * ww transactions can perform deadlock backoff if necessary, and that
+ * subsequent attempts to dma_resv_lock() @obj for @ctx will return
+ * -EALREADY.
+ *
+ * Return: true if the lock was acquired, false otherwise.
+ */
+static inline bool __must_check
+dma_resv_trylock_ctx(struct dma_resv *obj, struct ww_acquire_ctx *ctx)
+{
+	return ww_mutex_trylock(&obj->lock, ctx);
+}
+
 /**
  * dma_resv_trylock - trylock the reservation object
  * @obj: the reservation object
@@ -421,7 +442,7 @@ static inline int dma_resv_lock_slow_interruptible(struct dma_resv *obj,
  */
 static inline bool __must_check dma_resv_trylock(struct dma_resv *obj)
 {
-	return ww_mutex_trylock(&obj->lock, NULL);
+	return dma_resv_trylock_ctx(obj, NULL);
 }
 
 /**
-- 
2.44.0


  parent reply	other threads:[~2024-05-16 18:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 18:23 [CI v3 00/21] xe bo shrinker and exhaustive eviction Thomas Hellström
2024-05-16 18:23 ` [CI v3 01/21] drm/ttm: Allow TTM LRU list nodes of different types Thomas Hellström
2024-05-16 18:23 ` [CI v3 02/21] drm/ttm: Slightly clean up LRU list iteration Thomas Hellström
2024-05-16 18:23 ` [CI v3 03/21] drm/ttm: Use LRU hitches Thomas Hellström
2024-05-16 18:23 ` [CI v3 04/21] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves Thomas Hellström
2024-05-16 18:23 ` [CI v3 05/21] drm/ttm: Provide a generic LRU walker helper Thomas Hellström
2024-05-16 18:23 ` [CI v3 06/21] drm/ttm: Use restartable LRU and sleeping locks for swapping Thomas Hellström
2024-05-16 18:23 ` [CI v3 07/21] drm/ttm: sleeping evict lock Thomas Hellström
2024-05-16 18:23 ` [CI v3 08/21] drm/ttm: Add a virtual base class for graphics memory backup Thomas Hellström
2024-05-16 18:23 ` [CI v3 09/21] drm/ttm/pool: Provide a helper to shrink pages Thomas Hellström
2024-05-16 18:23 ` [CI v3 10/21] drm/ttm: Use fault-injection to test error paths Thomas Hellström
2024-05-16 18:23 ` [CI v3 11/21] drm/ttm, drm/xe: Add a shrinker for xe bos Thomas Hellström
2024-05-16 18:23 ` Thomas Hellström [this message]
2024-05-16 18:23 ` [CI v3 13/21] drm/exec: Rework contended locking Thomas Hellström
2024-05-16 18:23 ` [CI v3 14/21] drm/exec: drm_exec_trylock() Thomas Hellström
2024-05-16 18:23 ` [CI v3 15/21] drm/exec: Add a snapshot capability Thomas Hellström
2024-05-16 18:23 ` [CI v3 16/21] drm/exec: Introduce an evict mode Thomas Hellström
2024-05-16 18:23 ` [CI v3 17/21] drm/ttm: Support drm_exec locking for eviction and swapping Thomas Hellström
2024-05-16 18:23 ` [CI v3 18/21] drm/ttm: Convert ttm vm to using drm_exec Thomas Hellström
2024-05-16 18:23 ` [CI v3 19/21] drm/xe: Use drm_exec for fault locking Thomas Hellström
2024-05-16 18:23 ` [CI v3 20/21] drm/ttm: Use drm_exec_trylock for bo initialization Thomas Hellström
2024-05-16 18:23 ` [CI v3 21/21] drm/xe: Initial support for drm exec locking during validate Thomas Hellström
2024-05-16 18:29 ` ✓ CI.Patch_applied: success for xe bo shrinker and exhaustive eviction (rev4) Patchwork
2024-05-16 18:30 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-16 18:31 ` ✓ CI.KUnit: success " Patchwork
2024-05-16 18:43 ` ✓ CI.Build: " Patchwork
2024-05-16 18:45 ` ✗ CI.Hooks: failure " Patchwork
2024-05-16 18:46 ` ✗ CI.checksparse: warning " Patchwork
2024-05-16 19:16 ` ✗ CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516182339.3482-13-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox