Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>
Subject: [PATCH v6 0/2] Support/debug for slow GuC loads
Date: Fri, 17 May 2024 21:36:57 -0700	[thread overview]
Message-ID: <20240518043700.3264362-1-John.C.Harrison@Intel.com> (raw)

From: John Harrison <John.C.Harrison@Intel.com>

Sometimes the GuC load is slower that it should be. For end users,
that usually means some kind of thermal throttling issue. Internally,
there can be any number of bugs that cause it. So don't completely
fail to load, just cope with it and report the problem.

v2: Revert include order (review feedback from Lucas)
v3: Remove '_sysfs' from throttle file names and keep limit query in
the same file rather than moving elsewhere (review feedback from
Rodrigo). Fix the reporting of requested vs granted frequencies
(review feedback from Badal).
v4: Manually code the loop timeout/condition checking because helper
functions are not allowed (review feedback from Lucas/Rodrigo)
v5: Correct a #include, improve the comments even more, add units to a
#define (review feedback from Lucas).
v6: Fix typo in _wait32_not (review feedback from Lucas) and rebase.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (2):
  drm/xe: Make read_perf_limit_reasons globally accessible
  drm/xe/guc: Port over the slow GuC loading support from i915

 drivers/gpu/drm/xe/Makefile                   |   2 +-
 drivers/gpu/drm/xe/abi/guc_errors_abi.h       |  26 ++-
 drivers/gpu/drm/xe/regs/xe_guc_regs.h         |   2 +
 drivers/gpu/drm/xe/xe_gt_freq.c               |   4 +-
 ...e_gt_throttle_sysfs.c => xe_gt_throttle.c} |  26 +--
 drivers/gpu/drm/xe/xe_gt_throttle.h           |  17 ++
 drivers/gpu/drm/xe/xe_gt_throttle_sysfs.h     |  13 --
 drivers/gpu/drm/xe/xe_guc.c                   | 203 +++++++++++++++---
 drivers/gpu/drm/xe/xe_mmio.c                  |  61 ++++++
 drivers/gpu/drm/xe/xe_mmio.h                  |   2 +
 10 files changed, 293 insertions(+), 63 deletions(-)
 rename drivers/gpu/drm/xe/{xe_gt_throttle_sysfs.c => xe_gt_throttle.c} (86%)
 create mode 100644 drivers/gpu/drm/xe/xe_gt_throttle.h
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_throttle_sysfs.h

-- 
2.43.2


             reply	other threads:[~2024-05-18  4:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18  4:36 John.C.Harrison [this message]
2024-05-18  4:36 ` [PATCH v6 1/2] drm/xe: Make read_perf_limit_reasons globally accessible John.C.Harrison
2024-05-18  4:36 ` [PATCH v6 2/2] drm/xe/guc: Port over the slow GuC loading support from i915 John.C.Harrison
2024-05-18  4:42 ` ✓ CI.Patch_applied: success for Support/debug for slow GuC loads Patchwork
2024-05-18  4:43 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-18  4:44 ` ✓ CI.KUnit: success " Patchwork
2024-05-18  4:55 ` ✓ CI.Build: " Patchwork
2024-05-18  4:58 ` ✓ CI.Hooks: " Patchwork
2024-05-18  4:59 ` ✓ CI.checksparse: " Patchwork
2024-05-18  5:21 ` ✓ CI.BAT: " Patchwork
2024-05-18  6:35 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240518043700.3264362-1-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox