From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [CI v2 12/18] drm/xe/gt: break out gt_fini into sw vs hw state
Date: Mon, 20 May 2024 16:43:01 +0100 [thread overview]
Message-ID: <20240520154249.52888-30-matthew.auld@intel.com> (raw)
In-Reply-To: <20240520154249.52888-19-matthew.auld@intel.com>
Have a cleaner separation between hw vs sw.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/xe/xe_gt.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index e69a03ddd255..1abcc94f4b33 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -58,9 +58,17 @@
#include "xe_wa.h"
#include "xe_wopcm.h"
+static void gt_fini(struct drm_device *drm, void *arg)
+{
+ struct xe_gt *gt = arg;
+
+ destroy_workqueue(gt->ordered_wq);
+}
+
struct xe_gt *xe_gt_alloc(struct xe_tile *tile)
{
struct xe_gt *gt;
+ int err;
gt = drmm_kzalloc(&tile_to_xe(tile)->drm, sizeof(*gt), GFP_KERNEL);
if (!gt)
@@ -69,6 +77,10 @@ struct xe_gt *xe_gt_alloc(struct xe_tile *tile)
gt->tile = tile;
gt->ordered_wq = alloc_ordered_workqueue("gt-ordered-wq", 0);
+ err = drmm_add_action_or_reset(>_to_xe(gt)->drm, gt_fini, gt);
+ if (err)
+ return ERR_PTR(err);
+
return gt;
}
@@ -91,15 +103,9 @@ void xe_gt_sanitize(struct xe_gt *gt)
*/
void xe_gt_remove(struct xe_gt *gt)
{
- xe_uc_remove(>->uc);
-}
-
-static void gt_fini(struct drm_device *drm, void *arg)
-{
- struct xe_gt *gt = arg;
int i;
- destroy_workqueue(gt->ordered_wq);
+ xe_uc_remove(>->uc);
for (i = 0; i < XE_ENGINE_CLASS_MAX; ++i)
xe_hw_fence_irq_finish(>->fence_irq[i]);
@@ -560,7 +566,6 @@ int xe_gt_init(struct xe_gt *gt)
if (err)
return err;
- return drmm_add_action_or_reset(>_to_xe(gt)->drm, gt_fini, gt);
}
static int do_gt_reset(struct xe_gt *gt)
--
2.45.1
next prev parent reply other threads:[~2024-05-20 15:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 15:42 [CI v2 01/18] drm/xe/pci: remove broken driver_release Matthew Auld
2024-05-20 15:42 ` [CI v2 02/18] drm/xe: covert sysfs over to devm Matthew Auld
2024-05-20 15:42 ` [CI v2 03/18] drm/xe/ggtt: use drm_dev_enter to mark device section Matthew Auld
2024-05-20 15:42 ` [CI v2 04/18] drm/xe/guc: move guc_fini over to devm Matthew Auld
2024-05-20 15:42 ` [CI v2 05/18] drm/xe/guc: s/guc_fini/guc_fini_hw/ Matthew Auld
2024-05-20 15:42 ` [CI v2 06/18] drm/xe/guc_pc: move pc_fini to devm Matthew Auld
2024-05-20 15:42 ` [CI v2 07/18] drm/xe/guc_pc: s/pc_fini/pc_fini_hw/ Matthew Auld
2024-05-20 15:42 ` [CI v2 08/18] drm/xe/irq: move irq_uninstall over to devm Matthew Auld
2024-05-20 15:42 ` [CI v2 09/18] drm/xe/device: move flr " Matthew Auld
2024-05-20 15:42 ` [CI v2 10/18] drm/xe/device: move xe_device_sanitize over " Matthew Auld
2024-05-20 15:43 ` [CI v2 11/18] drm/xe/coredump: move " Matthew Auld
2024-05-20 15:43 ` Matthew Auld [this message]
2024-05-20 15:43 ` [CI v2 13/18] drm/xe: make gt_remove use devm Matthew Auld
2024-05-20 15:43 ` [CI v2 14/18] drm/xe/mmio: move mmio_fini over to devm Matthew Auld
2024-05-20 15:43 ` [CI v2 15/18] drm/xe: reset mmio mappings with devm Matthew Auld
2024-05-20 15:43 ` [CI v2 16/18] drm/xe/display: move display fini stuff to devm Matthew Auld
2024-05-20 15:43 ` [CI v2 17/18] drm/xe/display: stop calling domains_driver_remove twice Matthew Auld
2024-05-20 15:43 ` [CI v2 18/18] drm/xe/display: move device_remove over to drmm Matthew Auld
2024-05-20 15:51 ` ✓ CI.Patch_applied: success for series starting with [CI,v2,01/18] drm/xe/pci: remove broken driver_release Patchwork
2024-05-20 15:51 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-20 15:52 ` ✓ CI.KUnit: success " Patchwork
2024-05-20 16:04 ` ✓ CI.Build: " Patchwork
2024-05-20 16:06 ` ✗ CI.Hooks: failure " Patchwork
2024-05-20 16:08 ` ✓ CI.checksparse: success " Patchwork
2024-05-20 16:30 ` ✓ CI.BAT: " Patchwork
2024-05-20 18:18 ` ✓ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520154249.52888-30-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=andrzej.hajda@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox