From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Christian König" <christian.koenig@amd.com>,
"Somalapuram Amaranath" <Amaranath.Somalapuram@amd.com>,
"Matthew Brost" <matthew.brost@intel.com>,
dri-devel@lists.freedesktop.org
Subject: [RFC PATCH v3 20/21] drm/ttm: Use drm_exec_trylock for bo initialization
Date: Tue, 21 May 2024 09:16:38 +0200 [thread overview]
Message-ID: <20240521071639.77614-21-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240521071639.77614-1-thomas.hellstrom@linux.intel.com>
Buffer object initialization may be part of a drm_exec transaction.
Rather than using dma_resv_trylock, use drm_exec_trylock_obj().
RFC: This patch indicates to me that we should avoid the -ENOMEM failure
for drm_exec_trylock, Could probably use a sleeping lock here without
problems.
Cc: Christian König <christian.koenig@amd.com>
Cc: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <dri-devel@lists.freedesktop.org>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 8706502edcb1..70af66b5b86e 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -942,10 +942,17 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
/* passed reservation objects should already be locked,
* since otherwise lockdep will be angered in radeon.
*/
- if (!resv)
- WARN_ON(!dma_resv_trylock(bo->base.resv));
- else
+ if (!resv) {
+ if (ctx->exec) {
+ ret = drm_exec_trylock_obj(ctx->exec, &bo->base);
+ if (ret)
+ goto err_put;
+ } else {
+ WARN_ON(!dma_resv_trylock(bo->base.resv));
+ }
+ } else {
dma_resv_assert_held(resv);
+ }
ret = ttm_bo_validate(bo, placement, ctx);
if (unlikely(ret))
@@ -954,8 +961,12 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
return 0;
err_unlock:
- if (!resv)
- dma_resv_unlock(bo->base.resv);
+ if (!resv) {
+ if (ctx->exec)
+ drm_exec_unlock_obj(ctx->exec, &bo->base);
+ else
+ dma_resv_unlock(bo->base.resv);
+ }
err_put:
ttm_bo_put(bo);
--
2.44.0
next prev parent reply other threads:[~2024-05-21 7:18 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 7:16 [PATCH v3 00/21] TTM shrinker helpers and xe buffer object shrinker Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 01/21] drm/ttm: Allow TTM LRU list nodes of different types Thomas Hellström
2024-05-21 13:12 ` Matthew Brost
2024-05-28 9:16 ` Christian König
2024-05-21 7:16 ` [PATCH v3 02/21] drm/ttm: Slightly clean up LRU list iteration Thomas Hellström
2024-05-21 15:39 ` Matthew Brost
2024-05-28 9:19 ` Christian König
2024-05-21 7:16 ` [PATCH v3 03/21] drm/ttm: Use LRU hitches Thomas Hellström
2024-05-21 16:09 ` Matthew Brost
2024-05-21 7:16 ` [PATCH v3 04/21] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 05/21] drm/ttm: Provide a generic LRU walker helper Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 06/21] drm/ttm: Use the LRU walker helper for swapping Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 07/21] drm/ttm: Use the LRU walker for eviction Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 08/21] drm/ttm: Add a virtual base class for graphics memory backup Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 09/21] drm/ttm/pool: Provide a helper to shrink pages Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 10/21] drm/ttm: Use fault-injection to test error paths Thomas Hellström
2024-05-21 7:16 ` [PATCH v3 11/21] drm/ttm, drm/xe: Add a shrinker for xe bos Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 12/21] dma-buf/dma-resv: Introduce dma_resv_trylock_ctx() Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 13/21] drm/exec: Rework contended locking Thomas Hellström
2024-05-22 5:52 ` Christian König
2024-05-22 14:32 ` Thomas Hellström
2024-05-22 16:52 ` Christian König
2024-05-22 17:42 ` Thomas Hellström
2024-05-28 6:36 ` Thomas Hellström
2024-05-28 6:51 ` Christian König
2024-05-28 8:07 ` Thomas Hellström
2024-05-28 11:03 ` Christian König
2024-05-29 7:18 ` Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 14/21] drm/exec: Introduce a drm_exec_trylock_obj() function Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 15/21] drm/exec: Add a snapshot capability Thomas Hellström
2024-05-22 11:27 ` Christian König
2024-05-22 13:54 ` Thomas Hellström
2024-05-22 14:41 ` Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 16/21] drm/exec: Introduce an evict mode Thomas Hellström
2024-05-22 13:28 ` Christian König
2024-05-22 13:44 ` Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 17/21] drm/ttm: Support drm_exec locking for eviction and swapping Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 18/21] drm/ttm: Convert ttm vm to using drm_exec Thomas Hellström
2024-05-21 7:16 ` [RFC PATCH v3 19/21] drm/xe: Use drm_exec for fault locking Thomas Hellström
2024-05-21 7:16 ` Thomas Hellström [this message]
2024-05-21 7:16 ` [RFC PATCH v3 21/21] drm/xe: Initial support for drm exec locking during validate Thomas Hellström
2024-05-21 7:22 ` [PATCH v3 00/21] TTM shrinker helpers and xe buffer object shrinker Thomas Hellström
2024-05-21 7:23 ` ✓ CI.Patch_applied: success for TTM shrinker helpers and xe buffer object shrinker (rev3) Patchwork
2024-05-21 7:24 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-21 7:25 ` ✓ CI.KUnit: success " Patchwork
2024-05-21 7:37 ` ✓ CI.Build: " Patchwork
2024-05-21 7:39 ` ✗ CI.Hooks: failure " Patchwork
2024-05-21 7:41 ` ✗ CI.checksparse: warning " Patchwork
2024-05-21 8:03 ` ✓ CI.BAT: success " Patchwork
2024-05-21 9:09 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521071639.77614-21-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=Amaranath.Somalapuram@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox