From: Riana Tauro <riana.tauro@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: riana.tauro@intel.com, anshuman.gupta@intel.com,
rodrigo.vivi@intel.com, vinay.belgaumkar@intel.com
Subject: [PATCH v2 1/2] drm/xe: Standardize power gate registers
Date: Tue, 21 May 2024 14:52:00 +0530 [thread overview]
Message-ID: <20240521092201.4183305-2-riana.tauro@intel.com> (raw)
In-Reply-To: <20240521092201.4183305-1-riana.tauro@intel.com>
Standardize power gate registers
No functional changes
v2: change commit message (Rodrigo)
Signed-off-by: Riana Tauro <riana.tauro@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/xe/regs/xe_gt_regs.h | 8 +++-----
drivers/gpu/drm/xe/xe_gt_idle.c | 2 +-
drivers/gpu/drm/xe/xe_wa.c | 10 +++++-----
3 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
index 9cacdcfe27ff..7c173db7d585 100644
--- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
@@ -316,11 +316,9 @@
#define FORCEWAKE_GT XE_REG(0xa188)
-#define PG_ENABLE XE_REG(0xa210)
-#define VD2_MFXVDENC_POWERGATE_ENABLE REG_BIT(8)
-#define VD2_HCP_POWERGATE_ENABLE REG_BIT(7)
-#define VD0_MFXVDENC_POWERGATE_ENABLE REG_BIT(4)
-#define VD0_HCP_POWERGATE_ENABLE REG_BIT(3)
+#define POWERGATE_ENABLE XE_REG(0xa210)
+#define VDN_HCP_POWERGATE_ENABLE(n) REG_BIT(3 + 2 * (n))
+#define VDN_MFXVDENC_POWERGATE_ENABLE(n) REG_BIT(4 + 2 * (n))
#define CTC_MODE XE_REG(0xa26c)
#define CTC_SHIFT_PARAMETER_MASK REG_GENMASK(2, 1)
diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
index a4f6f0a96d05..4384f7e80258 100644
--- a/drivers/gpu/drm/xe/xe_gt_idle.c
+++ b/drivers/gpu/drm/xe/xe_gt_idle.c
@@ -202,7 +202,7 @@ void xe_gt_idle_disable_c6(struct xe_gt *gt)
xe_device_assert_mem_access(gt_to_xe(gt));
xe_force_wake_assert_held(gt_to_fw(gt), XE_FORCEWAKE_ALL);
- xe_mmio_write32(gt, PG_ENABLE, 0);
+ xe_mmio_write32(gt, POWERGATE_ENABLE, 0);
xe_mmio_write32(gt, RC_CONTROL, 0);
xe_mmio_write32(gt, RC_STATE, 0);
}
diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
index 05db53c1448c..64bc595fc727 100644
--- a/drivers/gpu/drm/xe/xe_wa.c
+++ b/drivers/gpu/drm/xe/xe_wa.c
@@ -238,11 +238,11 @@ static const struct xe_rtp_entry_sr gt_was[] = {
},
{ XE_RTP_NAME("14020316580"),
XE_RTP_RULES(MEDIA_VERSION(1301)),
- XE_RTP_ACTIONS(CLR(PG_ENABLE,
- VD0_HCP_POWERGATE_ENABLE |
- VD0_MFXVDENC_POWERGATE_ENABLE |
- VD2_HCP_POWERGATE_ENABLE |
- VD2_MFXVDENC_POWERGATE_ENABLE)),
+ XE_RTP_ACTIONS(CLR(POWERGATE_ENABLE,
+ VDN_HCP_POWERGATE_ENABLE(0) |
+ VDN_MFXVDENC_POWERGATE_ENABLE(0) |
+ VDN_HCP_POWERGATE_ENABLE(2) |
+ VDN_MFXVDENC_POWERGATE_ENABLE(2))),
},
{ XE_RTP_NAME("14019449301"),
XE_RTP_RULES(MEDIA_VERSION(1301), ENGINE_CLASS(VIDEO_DECODE)),
--
2.40.0
next prev parent reply other threads:[~2024-05-21 9:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 9:21 [PATCH v2 0/2] Enable Coarse Power Gating Riana Tauro
2024-05-21 9:15 ` ✓ CI.Patch_applied: success for Enable Coarse Power Gating (rev2) Patchwork
2024-05-21 9:15 ` ✓ CI.checkpatch: " Patchwork
2024-05-21 9:16 ` ✓ CI.KUnit: " Patchwork
2024-05-21 9:22 ` Riana Tauro [this message]
2024-05-21 9:22 ` [PATCH v2 2/2] drm/xe: Enable Coarse Power Gating Riana Tauro
2024-05-21 15:39 ` Rodrigo Vivi
2024-05-21 20:29 ` Belgaumkar, Vinay
2024-05-23 5:20 ` Riana Tauro
2024-05-21 9:28 ` ✓ CI.Build: success for Enable Coarse Power Gating (rev2) Patchwork
2024-05-21 9:30 ` ✓ CI.Hooks: " Patchwork
2024-05-21 9:32 ` ✓ CI.checksparse: " Patchwork
2024-05-21 9:53 ` ✗ CI.BAT: failure " Patchwork
2024-05-21 11:38 ` ✗ CI.FULL: " Patchwork
2024-05-21 13:45 ` ✓ CI.Patch_applied: success for Enable Coarse Power Gating (rev3) Patchwork
2024-05-21 13:45 ` ✓ CI.checkpatch: " Patchwork
2024-05-21 13:46 ` ✓ CI.KUnit: " Patchwork
2024-05-21 13:58 ` ✓ CI.Build: " Patchwork
2024-05-21 14:00 ` ✓ CI.Hooks: " Patchwork
2024-05-21 14:02 ` ✓ CI.checksparse: " Patchwork
2024-05-21 14:31 ` ✗ CI.BAT: failure " Patchwork
2024-05-21 18:47 ` ✗ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521092201.4183305-2-riana.tauro@intel.com \
--to=riana.tauro@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox