Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Subject: [PATCH] drm/xe/uc: Don't emit false error if running in execlist mode
Date: Tue, 21 May 2024 13:48:57 +0200	[thread overview]
Message-ID: <20240521114857.712-1-michal.wajdeczko@intel.com> (raw)

When running in execlist mode (using force_execlist=1 modparam)
we incorrectly select the error path in xe_uc_init(), leading to
an unwanted error message like this:

[ ] xe 0000:00:00.0: [drm] *ERROR* GT0: Failed to initialize uC (0000000000000000)

Fix that by doing early return like we do in other similar cases.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/xe/xe_uc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 0186eafc947d..85808706d1c8 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -51,7 +51,7 @@ int xe_uc_init(struct xe_uc *uc)
 		goto err;
 
 	if (!xe_device_uc_enabled(uc_to_xe(uc)))
-		goto err;
+		return 0;
 
 	ret = xe_wopcm_init(&uc->wopcm);
 	if (ret)
-- 
2.43.0


             reply	other threads:[~2024-05-21 11:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 11:48 Michal Wajdeczko [this message]
2024-05-21 14:53 ` ✓ CI.Patch_applied: success for drm/xe/uc: Don't emit false error if running in execlist mode Patchwork
2024-05-21 14:53 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-21 14:54 ` ✓ CI.KUnit: success " Patchwork
2024-05-21 15:06 ` ✓ CI.Build: " Patchwork
2024-05-21 15:08 ` ✓ CI.Hooks: " Patchwork
2024-05-21 15:10 ` ✓ CI.checksparse: " Patchwork
2024-05-21 15:39 ` ✓ CI.BAT: " Patchwork
2024-05-21 20:30 ` ✗ CI.FULL: failure " Patchwork
2024-05-22  9:27   ` Michal Wajdeczko
2024-05-22 16:08 ` [PATCH] " Daniele Ceraolo Spurio
2024-05-23  0:38 ` John Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240521114857.712-1-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox