Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI v3 06/18] drm/xe/guc_pc: move pc_fini to devm
Date: Wed, 22 May 2024 11:21:49 +0100	[thread overview]
Message-ID: <20240522102143.128069-24-matthew.auld@intel.com> (raw)
In-Reply-To: <20240522102143.128069-19-matthew.auld@intel.com>

Here we are touching the HW/GuC and presumably this should happen when
the device is removed. Currently if you hotunplug the device this is
skipped if there is already open driver instance.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_pc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index d10aab29651e..4164dab1ab66 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -893,7 +893,7 @@ int xe_guc_pc_stop(struct xe_guc_pc *pc)
  * @drm: DRM device
  * @arg: opaque pointer that should point to Xe_GuC_PC instance
  */
-static void xe_guc_pc_fini(struct drm_device *drm, void *arg)
+static void xe_guc_pc_fini(void *arg)
 {
 	struct xe_guc_pc *pc = arg;
 	struct xe_device *xe = pc_to_xe(pc);
@@ -941,5 +941,5 @@ int xe_guc_pc_init(struct xe_guc_pc *pc)
 
 	pc->bo = bo;
 
-	return drmm_add_action_or_reset(&xe->drm, xe_guc_pc_fini, pc);
+	return devm_add_action_or_reset(xe->drm.dev, xe_guc_pc_fini, pc);
 }
-- 
2.45.1


  parent reply	other threads:[~2024-05-22 10:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 10:21 [CI v3 01/18] drm/xe/pci: remove broken driver_release Matthew Auld
2024-05-22 10:21 ` [CI v3 02/18] drm/xe: covert sysfs over to devm Matthew Auld
2024-05-22 10:21 ` [CI v3 03/18] drm/xe/ggtt: use drm_dev_enter to mark device section Matthew Auld
2024-05-22 10:21 ` [CI v3 04/18] drm/xe/guc: move guc_fini over to devm Matthew Auld
2024-05-22 10:21 ` [CI v3 05/18] drm/xe/guc: s/guc_fini/guc_fini_hw/ Matthew Auld
2024-05-22 10:21 ` Matthew Auld [this message]
2024-05-22 10:21 ` [CI v3 07/18] drm/xe/guc_pc: s/pc_fini/pc_fini_hw/ Matthew Auld
2024-05-22 10:21 ` [CI v3 08/18] drm/xe/irq: move irq_uninstall over to devm Matthew Auld
2024-05-22 10:21 ` [CI v3 09/18] drm/xe/device: move flr " Matthew Auld
2024-05-22 10:21 ` [CI v3 10/18] drm/xe/device: move xe_device_sanitize over " Matthew Auld
2024-05-22 10:21 ` [CI v3 11/18] drm/xe/coredump: move " Matthew Auld
2024-05-22 10:21 ` [CI v3 12/18] drm/xe/gt: break out gt_fini into sw vs hw state Matthew Auld
2024-05-22 10:21 ` [CI v3 13/18] drm/xe: make gt_remove use devm Matthew Auld
2024-05-22 10:21 ` [CI v3 14/18] drm/xe/mmio: move mmio_fini over to devm Matthew Auld
2024-05-22 10:21 ` [CI v3 15/18] drm/xe: reset mmio mappings with devm Matthew Auld
2024-05-22 10:21 ` [CI v3 16/18] drm/xe/display: move display fini stuff to devm Matthew Auld
2024-05-22 10:22 ` [CI v3 17/18] drm/xe/display: stop calling domains_driver_remove twice Matthew Auld
2024-05-22 10:22 ` [CI v3 18/18] drm/xe/display: move device_remove over to drmm Matthew Auld
2024-05-22 10:28 ` ✓ CI.Patch_applied: success for series starting with [CI,v3,01/18] drm/xe/pci: remove broken driver_release Patchwork
2024-05-22 10:28 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-22 10:29 ` ✓ CI.KUnit: success " Patchwork
2024-05-22 10:41 ` ✓ CI.Build: " Patchwork
2024-05-22 10:43 ` ✗ CI.Hooks: failure " Patchwork
2024-05-22 10:45 ` ✓ CI.checksparse: success " Patchwork
2024-05-22 11:36 ` ✗ CI.BAT: failure " Patchwork
2024-05-22 13:44 ` ✗ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240522102143.128069-24-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox