Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pallavi Mishra <pallavi.mishra@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com, Pallavi Mishra <pallavi.mishra@intel.com>
Subject: [PATCH] drm/xe/xe2: Enable Priority Mem Read
Date: Sat, 25 May 2024 06:19:33 +0530	[thread overview]
Message-ID: <20240525004933.1124012-1-pallavi.mishra@intel.com> (raw)

Enable feature to allow memory reads to take a
priority memory path. This will reduce latency
on the read path, but may introduce RAW hazards.

Bspec: 45845, 60237, 60187, 60188

Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_engine_regs.h | 1 +
 drivers/gpu/drm/xe/xe_hw_engine.c        | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/xe/regs/xe_engine_regs.h b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
index 263ffc7bc2ef..4e8f9a61f0bf 100644
--- a/drivers/gpu/drm/xe/regs/xe_engine_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
@@ -104,6 +104,7 @@
 #define CSFE_CHICKEN1(base)			XE_REG((base) + 0xd4, XE_REG_OPTION_MASKED)
 #define   GHWSP_CSB_REPORT_DIS			REG_BIT(15)
 #define   PPHWSP_CSB_AND_TIMESTAMP_REPORT_DIS	REG_BIT(14)
+#define   CS_PRIORITY_MEM_READ			REG_BIT(7)
 
 #define FF_SLICE_CS_CHICKEN1(base)		XE_REG((base) + 0xe0, XE_REG_OPTION_MASKED)
 #define   FFSC_PERCTX_PREEMPT_CTRL		REG_BIT(14)
diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
index de1aefaa2335..34aa8b5270b0 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b/drivers/gpu/drm/xe/xe_hw_engine.c
@@ -424,6 +424,13 @@ hw_engine_setup_default_state(struct xe_hw_engine *hwe)
 					   0xA,
 					   XE_RTP_ACTION_FLAG(ENGINE_BASE)))
 		},
+		/* Enable Priority Mem Read */
+		{ XE_RTP_NAME("Priority_Mem_Read"),
+		  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(2000, 2004)),
+		  XE_RTP_ACTIONS(SET(CSFE_CHICKEN1(0),
+				     CS_PRIORITY_MEM_READ)),
+		  XE_RTP_ACTION_FLAG(ENGINE_BASE),
+		},
 		{}
 	};
 
-- 
2.25.1


             reply	other threads:[~2024-05-25  0:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-25  0:49 Pallavi Mishra [this message]
2024-05-25  0:46 ` ✓ CI.Patch_applied: success for drm/xe/xe2: Enable Priority Mem Read Patchwork
2024-05-25  0:46 ` ✓ CI.checkpatch: " Patchwork
2024-05-25  0:47 ` ✓ CI.KUnit: " Patchwork
2024-05-25  0:59 ` ✓ CI.Build: " Patchwork
2024-05-25  1:01 ` ✓ CI.Hooks: " Patchwork
2024-05-25  1:03 ` ✓ CI.checksparse: " Patchwork
2024-05-25  1:31 ` ✗ CI.BAT: failure " Patchwork
2024-05-27 14:05 ` ✓ CI.FULL: success " Patchwork
2024-05-28 16:34 ` [PATCH] " Matt Roper
2024-05-29 16:00   ` Mishra, Pallavi
2024-05-29 16:45     ` Matt Roper
2024-05-29 20:37       ` Mishra, Pallavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240525004933.1124012-1-pallavi.mishra@intel.com \
    --to=pallavi.mishra@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox