From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI v5 19/20] drm/ttm: Use drm_exec_trylock for bo initialization
Date: Tue, 28 May 2024 11:55:01 +0200 [thread overview]
Message-ID: <20240528095503.90177-20-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240528095503.90177-1-thomas.hellstrom@linux.intel.com>
Buffer object initialization may be part of a drm_exec transaction.
Rather than using dma_resv_trylock, use drm_exec_trylock_obj().
RFC: This patch indicates to me that we should avoid the -ENOMEM failure
for drm_exec_trylock, Could probably use a sleeping lock here without
problems.
Cc: Christian König <christian.koenig@amd.com>
Cc: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <dri-devel@lists.freedesktop.org>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 8706502edcb1..216aeb6d7941 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -942,10 +942,18 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
/* passed reservation objects should already be locked,
* since otherwise lockdep will be angered in radeon.
*/
- if (!resv)
- WARN_ON(!dma_resv_trylock(bo->base.resv));
- else
+ if (!resv) {
+ if (ctx->exec) {
+ ret = drm_exec_sanitize_for_trylock(ctx->exec);
+ if (ret)
+ goto err_put;
+ WARN_ON(drm_exec_trylock_obj(ctx->exec, &bo->base));
+ } else {
+ WARN_ON(!dma_resv_trylock(bo->base.resv));
+ }
+ } else {
dma_resv_assert_held(resv);
+ }
ret = ttm_bo_validate(bo, placement, ctx);
if (unlikely(ret))
@@ -954,8 +962,12 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
return 0;
err_unlock:
- if (!resv)
- dma_resv_unlock(bo->base.resv);
+ if (!resv) {
+ if (ctx->exec)
+ drm_exec_unlock_obj(ctx->exec, &bo->base);
+ else
+ dma_resv_unlock(bo->base.resv);
+ }
err_put:
ttm_bo_put(bo);
--
2.44.0
next prev parent reply other threads:[~2024-05-28 9:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 9:54 [CI v5 00/20] xe bo shrinker and exhaustive eviction Thomas Hellström
2024-05-28 9:54 ` [CI v5 01/20] drm/ttm: Allow TTM LRU list nodes of different types Thomas Hellström
2024-05-28 9:54 ` [CI v5 02/20] drm/ttm: Slightly clean up LRU list iteration Thomas Hellström
2024-05-28 9:54 ` [CI v5 03/20] drm/ttm: Use LRU hitches Thomas Hellström
2024-05-28 9:54 ` [CI v5 04/20] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves Thomas Hellström
2024-05-28 9:54 ` [CI v5 05/20] drm/ttm: Provide a generic LRU walker helper Thomas Hellström
2024-05-28 9:54 ` [CI v5 06/20] drm/ttm: Use the LRU walker helper for swapping Thomas Hellström
2024-05-28 9:54 ` [CI v5 07/20] drm/ttm: Use the LRU walker for eviction Thomas Hellström
2024-05-28 9:54 ` [CI v5 08/20] drm/ttm: Add a virtual base class for graphics memory backup Thomas Hellström
2024-05-28 9:54 ` [CI v5 09/20] drm/ttm/pool: Provide a helper to shrink pages Thomas Hellström
2024-05-28 9:54 ` [CI v5 10/20] drm/ttm: Use fault-injection to test error paths Thomas Hellström
2024-05-28 9:54 ` [CI v5 11/20] drm/ttm, drm/xe: Add a shrinker for xe bos Thomas Hellström
2024-05-28 9:54 ` [CI v5 12/20] dma-buf/dma-resv: Introduce dma_resv_trylock_ctx() Thomas Hellström
2024-05-28 9:54 ` [CI v5 13/20] drm/exec: Add a snapshot capability Thomas Hellström
2024-05-28 9:54 ` [CI v5 14/20] drm/exec: Introduce an evict mode Thomas Hellström
2024-05-28 9:54 ` [CI v5 15/20] drm/ttm: Support drm_exec locking for eviction and swapping Thomas Hellström
2024-05-28 9:54 ` [CI v5 16/20] drm/ttm: Convert ttm vm to using drm_exec Thomas Hellström
2024-05-28 9:54 ` [CI v5 17/20] drm/xe: Use drm_exec for fault locking Thomas Hellström
2024-05-28 9:55 ` [CI v5 18/20] drm/exec: Introduce drm_exec_sanitize_for_trylock Thomas Hellström
2024-05-28 9:55 ` Thomas Hellström [this message]
2024-05-28 9:55 ` [CI v5 20/20] drm/xe: Initial support for drm exec locking during validate Thomas Hellström
2024-05-28 10:02 ` ✓ CI.Patch_applied: success for xe bo shrinker and exhaustive eviction (rev6) Patchwork
2024-05-28 10:02 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-28 10:04 ` ✗ CI.KUnit: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528095503.90177-20-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox