Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI v5 18/22] drm/exec: Introduce drm_exec_sanitize_for_trylock
Date: Tue, 28 May 2024 14:33:39 +0200	[thread overview]
Message-ID: <20240528123343.169970-19-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240528123343.169970-1-thomas.hellstrom@linux.intel.com>

In some situations, we don't want to allow memory allocation or locking
of a contended lock to cause a drm_exec_trylock_obj() to fail.

Introduce a function to move the point-of-failure if desired.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/drm_exec.c | 33 +++++++++++++++++++++++++++++++++
 include/drm/drm_exec.h     |  2 +-
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
index c70d8b01effb..98c49d864984 100644
--- a/drivers/gpu/drm/drm_exec.c
+++ b/drivers/gpu/drm/drm_exec.c
@@ -189,6 +189,10 @@ static int drm_exec_obj_locked(struct drm_exec *exec,
 		exec->objects = tmp;
 		exec->max_objects += PAGE_SIZE / sizeof(void *);
 	}
+
+	if (!obj)
+		return 0;
+
 	drm_gem_object_get(obj);
 	exec->objects[exec->num_objects++] = obj;
 
@@ -241,6 +245,35 @@ static int drm_exec_lock_contended(struct drm_exec *exec)
 	return ret;
 }
 
+/**
+ * drm_exec_sanitize_for_trylock() - Sanitize the drm_exec state for a
+ * traditional trylock.
+ * @exec: The drm_exec object.
+ *
+ * drm_exec_trylock_obj() might fail because there is a contended lock
+ * in the transaction, or because of memory allocation failure.
+ * Calling this function before a drm_exec_trylock_obj() and with no
+ * drm_exec interactions inbetween the calls, will ensure that does not
+ * happen. Any failures will be reported by this function.
+ *
+ * Return: -EINTR if a wait for contended lock was interrupted by a signal,
+ * -ENOMEM on memory allocation failure.
+ */
+int drm_exec_sanitize_for_trylock(struct drm_exec *exec)
+{
+	int ret;
+
+	might_sleep();
+	might_alloc(GFP_KERNEL);
+
+	ret = drm_exec_lock_contended(exec);
+	if (ret)
+		return ret;
+
+	return drm_exec_obj_locked(exec, NULL, GFP_KERNEL);
+}
+EXPORT_SYMBOL(drm_exec_sanitize_for_trylock);
+
 /**
  * drm_exec_trylock_obj - trylock a GEM object for use
  * @exec: the drm_exec object with the state.
diff --git a/include/drm/drm_exec.h b/include/drm/drm_exec.h
index cafeec5dddfe..a236d2bf91a8 100644
--- a/include/drm/drm_exec.h
+++ b/include/drm/drm_exec.h
@@ -182,6 +182,6 @@ int drm_exec_prepare_array(struct drm_exec *exec,
 			   unsigned int num_fences);
 void drm_exec_snapshot(struct drm_exec *exec, struct drm_exec_snapshot *snap);
 void drm_exec_restore(struct drm_exec *exec, struct drm_exec_snapshot *snap);
-
+int drm_exec_sanitize_for_trylock(struct drm_exec *exec);
 
 #endif
-- 
2.44.0


  parent reply	other threads:[~2024-05-28 12:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 12:33 [CI v5 00/20] xe bo shrinker and exhaustive eviction Thomas Hellström
2024-05-28 12:33 ` [CI v5 01/22] drm/ttm: Allow TTM LRU list nodes of different types Thomas Hellström
2024-05-28 12:33 ` [CI v5 02/22] drm/ttm: Slightly clean up LRU list iteration Thomas Hellström
2024-05-28 12:33 ` [CI v5 03/22] drm/ttm: Use LRU hitches Thomas Hellström
2024-05-28 12:33 ` [CI v5 04/22] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves Thomas Hellström
2024-05-28 12:33 ` [CI v5 05/22] drm/ttm: Provide a generic LRU walker helper Thomas Hellström
2024-05-28 12:33 ` [CI v5 06/22] drm/ttm: Use the LRU walker helper for swapping Thomas Hellström
2024-05-28 12:33 ` [CI v5 07/22] drm/ttm: Use the LRU walker for eviction Thomas Hellström
2024-05-28 12:33 ` [CI v5 08/22] drm/ttm: Add a virtual base class for graphics memory backup Thomas Hellström
2024-05-28 12:33 ` [CI v5 09/22] drm/ttm/pool: Provide a helper to shrink pages Thomas Hellström
2024-05-28 12:33 ` [CI v5 10/22] drm/ttm: Use fault-injection to test error paths Thomas Hellström
2024-05-28 12:33 ` [CI v5 11/22] drm/ttm, drm/xe: Add a shrinker for xe bos Thomas Hellström
2024-05-28 12:33 ` [CI v5 12/22] dma-buf/dma-resv: Introduce dma_resv_trylock_ctx() Thomas Hellström
2024-05-28 12:33 ` [CI v5 13/22] drm/exec: Add a snapshot capability Thomas Hellström
2024-05-28 12:33 ` [CI v5 14/22] drm/exec: Introduce an evict mode Thomas Hellström
2024-05-28 12:33 ` [CI v5 15/22] drm/ttm: Support drm_exec locking for eviction and swapping Thomas Hellström
2024-05-28 12:33 ` [CI v5 16/22] drm/ttm: Convert ttm vm to using drm_exec Thomas Hellström
2024-05-28 12:33 ` [CI v5 17/22] drm/xe: Use drm_exec for fault locking Thomas Hellström
2024-05-28 12:33 ` Thomas Hellström [this message]
2024-05-28 12:33 ` [CI v5 19/22] drm/ttm: Use drm_exec_trylock for bo initialization Thomas Hellström
2024-05-28 12:33 ` [CI v5 20/22] drm/xe: Initial support for drm exec locking during validate Thomas Hellström
2024-05-28 12:33 ` [CI v5 21/22] HAX: Add a missing include Thomas Hellström
2024-05-28 12:33 ` [CI v5 22/22] HAX: drm/tests: Add a missing Kconfig select Thomas Hellström
2024-05-28 12:40 ` ✓ CI.Patch_applied: success for xe bo shrinker and exhaustive eviction (rev7) Patchwork
2024-05-28 12:41 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-28 12:42 ` ✓ CI.KUnit: success " Patchwork
2024-05-28 12:53 ` ✓ CI.Build: " Patchwork
2024-05-28 12:54 ` ✗ CI.Hooks: failure " Patchwork
2024-05-28 12:55 ` ✗ CI.checksparse: warning " Patchwork
2024-05-28 13:20 ` ✓ CI.BAT: success " Patchwork
2024-05-28 14:23 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528123343.169970-19-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox