From: Oak Zeng <oak.zeng@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI v3 24/26] drm/xe: Add dma_addr res cursor
Date: Tue, 28 May 2024 21:19:22 -0400 [thread overview]
Message-ID: <20240529011924.4125173-24-oak.zeng@intel.com> (raw)
In-Reply-To: <20240529011924.4125173-1-oak.zeng@intel.com>
From: Matthew Brost <matthew.brost@intel.com>
v1: Modify dma_addr res cursor to use new dma map API (Oak)
With the new dma map API, we don't need a dma_address
array to hold dma addresses. Instead, dma address is
pre-allocated from iova address space. Modify dma_addr
res cursor for this purpose.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Oak Zeng <oak.zeng@intel.com>
---
drivers/gpu/drm/xe/xe_res_cursor.h | 38 +++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_res_cursor.h b/drivers/gpu/drm/xe/xe_res_cursor.h
index 0a306963aa8e..f4f3c296035e 100644
--- a/drivers/gpu/drm/xe/xe_res_cursor.h
+++ b/drivers/gpu/drm/xe/xe_res_cursor.h
@@ -46,6 +46,7 @@ struct xe_res_cursor {
u32 mem_type;
struct scatterlist *sgl;
struct drm_buddy *mm;
+ bool dma_addr;
};
static struct drm_buddy *xe_res_get_buddy(struct ttm_resource *res)
@@ -71,6 +72,7 @@ static inline void xe_res_first(struct ttm_resource *res,
struct xe_res_cursor *cur)
{
cur->sgl = NULL;
+ cur->dma_addr = false;
if (!res)
goto fallback;
@@ -160,6 +162,7 @@ static inline void xe_res_first_sg(const struct sg_table *sg,
XE_WARN_ON(!IS_ALIGNED(start, PAGE_SIZE) ||
!IS_ALIGNED(size, PAGE_SIZE));
cur->node = NULL;
+ cur->dma_addr = false;
cur->start = start;
cur->remaining = size;
cur->size = 0;
@@ -168,6 +171,29 @@ static inline void xe_res_first_sg(const struct sg_table *sg,
__xe_res_sg_next(cur);
}
+/**
+ * xe_res_first_dma - initialize a xe_res_cursor with dma_addr
+ *
+ * @dma_addr: dma address
+ * @start: Start of the range
+ * @size: Size of the range
+ * @cur: cursor object to initialize
+ *
+ * Start walking over the range of allocations between @start and @size.
+ */
+static inline void xe_res_first_dma(const dma_addr_t dma_addr,
+ u64 size, struct xe_res_cursor *cur)
+{
+ XE_WARN_ON(!IS_ALIGNED(size, PAGE_SIZE));
+
+ cur->node = NULL;
+ cur->start = dma_addr;
+ cur->remaining = size;
+ cur->sgl = NULL;
+ cur->dma_addr = true;
+ cur->mem_type = XE_PL_TT;
+}
+
/**
* xe_res_next - advance the cursor
*
@@ -194,6 +220,11 @@ static inline void xe_res_next(struct xe_res_cursor *cur, u64 size)
return;
}
+ if (cur->dma_addr) {
+ cur->start += size;
+ return;
+ }
+
if (cur->sgl) {
cur->start += size;
__xe_res_sg_next(cur);
@@ -235,6 +266,11 @@ static inline void xe_res_next(struct xe_res_cursor *cur, u64 size)
*/
static inline u64 xe_res_dma(const struct xe_res_cursor *cur)
{
- return cur->sgl ? sg_dma_address(cur->sgl) + cur->start : cur->start;
+ if (cur->dma_addr)
+ return cur->start;
+ else if (cur->sgl)
+ return sg_dma_address(cur->sgl) + cur->start;
+ else
+ return cur->start;
}
#endif
--
2.26.3
next prev parent reply other threads:[~2024-05-29 1:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 1:18 [CI v3 01/26] mm/hmm: let users to tag specific PFNs Oak Zeng
2024-05-29 1:14 ` ✗ CI.Patch_applied: failure for series starting with [CI,v3,01/26] " Patchwork
2024-05-29 1:19 ` [CI v3 02/26] dma-mapping: provide an interface to allocate IOVA Oak Zeng
2024-05-29 1:19 ` [CI v3 03/26] dma-mapping: provide callbacks to link/unlink pages to specific IOVA Oak Zeng
2024-05-29 1:19 ` [CI v3 04/26] iommu/dma: Provide an interface to allow preallocate IOVA Oak Zeng
2024-05-29 1:19 ` [CI v3 05/26] iommu/dma: Prepare map/unmap page functions to receive IOVA Oak Zeng
2024-05-29 1:19 ` [CI v3 06/26] iommu/dma: Implement link/unlink page callbacks Oak Zeng
2024-05-29 1:19 ` [CI v3 07/26] drm: move xe_sg_segment_size to drm layer Oak Zeng
2024-05-29 1:19 ` [CI v3 08/26] drm: Move GPUVA_START/LAST to drm_gpuvm.h Oak Zeng
2024-05-29 1:19 ` [CI v3 09/26] drm/svm: add a mm field to drm_gpuvm struct Oak Zeng
2024-05-29 1:19 ` [CI v3 10/26] drm/svm: introduce drm_mem_region concept Oak Zeng
2024-05-29 1:19 ` [CI v3 11/26] drm/svm: introduce hmmptr and helper functions Oak Zeng
2024-05-29 1:19 ` [CI v3 12/26] drm/svm: Introduce helper to remap drm memory region Oak Zeng
2024-05-29 1:19 ` [CI v3 13/26] drm/svm: handle CPU page fault Oak Zeng
2024-05-29 1:19 ` [CI v3 14/26] drm/svm: Migrate a range of hmmptr to vram Oak Zeng
2024-05-29 1:19 ` [CI v3 15/26] drm/svm: Add DRM SVM documentation Oak Zeng
2024-05-29 1:19 ` [CI v3 16/26] drm/xe: s/xe_tile_migrate_engine/xe_tile_migrate_exec_queue Oak Zeng
2024-05-29 1:19 ` [CI v3 17/26] drm/xe: Add xe_vm_pgtable_update_op to xe_vma_ops Oak Zeng
2024-05-29 1:19 ` [CI v3 18/26] drm/xe: Convert multiple bind ops into single job Oak Zeng
2024-05-29 1:19 ` [CI v3 19/26] drm/xe: Update VM trace events Oak Zeng
2024-05-29 1:19 ` [CI v3 20/26] drm/xe: Update PT layer with better error handling Oak Zeng
2024-05-29 1:19 ` [CI v3 21/26] drm/xe: Retry BO allocation Oak Zeng
2024-05-29 1:19 ` [CI v3 22/26] drm/xe: Rework GPU page fault handling Oak Zeng
2024-05-29 1:19 ` [CI v3 23/26] drm/xe/uapi: Add DRM_XE_VM_BIND_FLAG_SYSTEM_ALLOCATOR flag Oak Zeng
2024-05-29 1:19 ` Oak Zeng [this message]
2024-05-29 1:19 ` [CI v3 25/26] drm/xe: Use drm_mem_region for xe Oak Zeng
2024-05-29 1:19 ` [CI v3 26/26] drm/xe: use drm_hmmptr in xe Oak Zeng
-- strict thread matches above, loose matches on Subject: below --
2024-05-30 0:47 [CI v3 01/26] mm/hmm: let users to tag specific PFNs Oak Zeng
2024-05-30 0:47 ` [CI v3 24/26] drm/xe: Add dma_addr res cursor Oak Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529011924.4125173-24-oak.zeng@intel.com \
--to=oak.zeng@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox