From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Matt Roper <matthew.d.roper@intel.com>
Subject: [PATCH v2 1/5] drm/xe: Move XEHP_MTCFG_ADDR register definition to xe_regs.h
Date: Thu, 30 May 2024 15:35:23 +0200 [thread overview]
Message-ID: <20240530133527.1328-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240530133527.1328-1-michal.wajdeczko@intel.com>
We should not define registers directly in the code while we have
dedicated files for all register definitions. Move XEHP_MTCFG_ADDR
to regs/xe_regs.h
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/xe/regs/xe_regs.h | 3 +++
drivers/gpu/drm/xe/xe_mmio.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/regs/xe_regs.h b/drivers/gpu/drm/xe/regs/xe_regs.h
index 722fb6dbb72e..23e33ec84902 100644
--- a/drivers/gpu/drm/xe/regs/xe_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_regs.h
@@ -30,6 +30,9 @@
#define XEHP_CLOCK_GATE_DIS XE_REG(0x101014)
#define SGSI_SIDECLK_DIS REG_BIT(17)
+#define XEHP_MTCFG_ADDR XE_REG(0x101800)
+#define TILE_COUNT REG_GENMASK(15, 8)
+
#define GGC XE_REG(0x108040)
#define GMS_MASK REG_GENMASK(15, 8)
#define GGMS_MASK REG_GENMASK(7, 6)
diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
index 248e93ec6df7..44bff104c011 100644
--- a/drivers/gpu/drm/xe/xe_mmio.c
+++ b/drivers/gpu/drm/xe/xe_mmio.c
@@ -28,9 +28,6 @@
#include "xe_sriov.h"
#include "xe_tile.h"
-#define XEHP_MTCFG_ADDR XE_REG(0x101800)
-#define TILE_COUNT REG_GENMASK(15, 8)
-
#define BAR_SIZE_SHIFT 20
static void
--
2.43.0
next prev parent reply other threads:[~2024-05-30 13:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 13:35 [PATCH v2 0/5] VF: Setup VRAM based on received config data Michal Wajdeczko
2024-05-30 13:35 ` Michal Wajdeczko [this message]
2024-05-30 13:35 ` [PATCH v2 2/5] drm/xe: Move BAR definitions to dedicated file Michal Wajdeczko
2024-05-30 13:35 ` [PATCH v2 3/5] drm/xe: Drop xe_ prefix from static functions in xe_mmio.c Michal Wajdeczko
2024-05-30 15:25 ` Matt Roper
2024-05-30 13:35 ` [PATCH v2 4/5] drm/xe: Promote VRAM initialization function to own file Michal Wajdeczko
2024-05-30 13:35 ` [PATCH v2 5/5] drm/xe/vf: Setup VRAM based on received config data Michal Wajdeczko
2024-05-30 14:14 ` ✓ CI.Patch_applied: success for VF: Setup VRAM based on received config data (rev2) Patchwork
2024-05-30 14:14 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-30 14:15 ` ✓ CI.KUnit: success " Patchwork
2024-05-30 14:27 ` ✓ CI.Build: " Patchwork
2024-05-30 14:27 ` ✗ CI.Hooks: failure " Patchwork
2024-05-30 14:28 ` ✓ CI.checksparse: success " Patchwork
2024-05-30 14:52 ` ✓ CI.BAT: " Patchwork
2024-05-30 17:08 ` ✗ CI.FULL: failure " Patchwork
2024-05-30 21:45 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530133527.1328-2-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox