Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: lucas.demarchi@intel.com,
	"Radhakrishna Sripada" <radhakrishna.sripada@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v3 3/6] drm/xe/trace: Print device_id in xe_trace_bo events
Date: Thu, 30 May 2024 08:13:10 -0700	[thread overview]
Message-ID: <20240530151313.2284182-4-radhakrishna.sripada@intel.com> (raw)
In-Reply-To: <20240530151313.2284182-1-radhakrishna.sripada@intel.com>

In multi-gpu environments it is important to know the device
bo/vm belongs to. The tracing information includes the device_id
to indicate the device the event is associated with.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/xe/xe_trace_bo.h | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_trace_bo.h
index 6d90f3f42d54..88204d4988fd 100644
--- a/drivers/gpu/drm/xe/xe_trace_bo.h
+++ b/drivers/gpu/drm/xe/xe_trace_bo.h
@@ -24,16 +24,20 @@ DECLARE_EVENT_CLASS(xe_bo,
 			     __field(size_t, size)
 			     __field(u32, flags)
 			     __field(struct xe_vm *, vm)
+			     __array(char, device_id, 12)
 			     ),
 
 		    TP_fast_assign(
 			   __entry->size = bo->size;
 			   __entry->flags = bo->flags;
 			   __entry->vm = bo->vm;
+			   strscpy(__entry->device_id,
+				   dev_name(xe_bo_device(bo)->drm.dev), 12);
 			   ),
 
-		    TP_printk("size=%zu, flags=0x%02x, vm=%p",
-			      __entry->size, __entry->flags, __entry->vm)
+		    TP_printk("dev: %s: size=%zu, flags=0x%02x, vm=%p",
+			      __entry->device_id, __entry->size,
+			      __entry->flags, __entry->vm)
 );
 
 DEFINE_EVENT(xe_bo, xe_bo_cpu_fault,
@@ -78,6 +82,7 @@ DECLARE_EVENT_CLASS(xe_vma,
 			     __field(u64, start)
 			     __field(u64, end)
 			     __field(u64, ptr)
+			     __array(char, device_id, 12)
 			     ),
 
 		    TP_fast_assign(
@@ -86,10 +91,11 @@ DECLARE_EVENT_CLASS(xe_vma,
 			   __entry->start = xe_vma_start(vma);
 			   __entry->end = xe_vma_end(vma) - 1;
 			   __entry->ptr = xe_vma_userptr(vma);
+			   strscpy(__entry->device_id, dev_name(xe_vma_vm(vma)->xe->drm.dev), 12);
 			   ),
 
-		    TP_printk("vma=%p, asid=0x%05x, start=0x%012llx, end=0x%012llx, userptr=0x%012llx,",
-			      __entry->vma, __entry->asid, __entry->start,
+		    TP_printk("dev: %s: vma=%p, asid=0x%05x, start=0x%012llx, end=0x%012llx, userptr=0x%012llx,",
+			      __entry->device_id, __entry->vma, __entry->asid, __entry->start,
 			      __entry->end, __entry->ptr)
 )
 
@@ -175,15 +181,17 @@ DECLARE_EVENT_CLASS(xe_vm,
 		    TP_STRUCT__entry(
 			     __field(struct xe_vm *, vm)
 			     __field(u32, asid)
+			     __array(char, device_id, 12)
 			     ),
 
 		    TP_fast_assign(
 			   __entry->vm = vm;
 			   __entry->asid = vm->usm.asid;
+			   strscpy(__entry->device_id, dev_name(vm->xe->drm.dev), 12);
 			   ),
 
-		    TP_printk("vm=%p, asid=0x%05x",  __entry->vm,
-			      __entry->asid)
+		    TP_printk("dev: %s: vm=%p, asid=0x%05x", __entry->device_id,
+			      __entry->vm,  __entry->asid)
 );
 
 DEFINE_EVENT(xe_vm, xe_vm_kill,
-- 
2.34.1


  parent reply	other threads:[~2024-05-30 15:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 15:13 [PATCH v3 0/6] Tracing cleanup and add mmio tracing Radhakrishna Sripada
2024-05-30 15:13 ` [PATCH v3 1/6] drm/xe/trace: Extract bo, vm, vma traces Radhakrishna Sripada
2024-05-31 14:33   ` Gustavo Sousa
2024-05-30 15:13 ` [PATCH v3 2/6] drm/xe/trace: Extract guc related traces Radhakrishna Sripada
2024-05-31 14:34   ` Gustavo Sousa
2024-05-30 15:13 ` Radhakrishna Sripada [this message]
2024-05-31 20:07   ` [PATCH v3 3/6] drm/xe/trace: Print device_id in xe_trace_bo events Gustavo Sousa
2024-05-30 15:13 ` [PATCH v3 4/6] drm/xe/trace: Print device_id in xe_trace_guc events Radhakrishna Sripada
2024-06-03 14:16   ` Gustavo Sousa
2024-06-03 15:03     ` Sripada, Radhakrishna
2024-05-30 15:13 ` [PATCH v3 5/6] drm/xe/trace: Print device_id in xe_trace events Radhakrishna Sripada
2024-05-30 15:13 ` [PATCH v3 6/6] drm/xe: Add reg read/write trace Radhakrishna Sripada
2024-06-03 15:44   ` Gustavo Sousa
2024-06-03 15:49     ` Sripada, Radhakrishna
2024-05-30 15:32 ` [PATCH v3 0/6] Tracing cleanup and add mmio tracing Jani Nikula
2024-05-30 16:26 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-30 16:27 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-30 16:28 ` ✓ CI.KUnit: success " Patchwork
2024-05-30 16:39 ` ✓ CI.Build: " Patchwork
2024-05-30 16:40 ` ✗ CI.Hooks: failure " Patchwork
2024-05-30 16:41 ` ✓ CI.checksparse: success " Patchwork
2024-05-30 17:16 ` ✓ CI.BAT: " Patchwork
2024-05-30 21:22 ` ✗ CI.FULL: failure " Patchwork
2024-06-03 15:50 ` [PATCH v3 0/6] " Gustavo Sousa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240530151313.2284182-4-radhakrishna.sripada@intel.com \
    --to=radhakrishna.sripada@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox