From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH] drm/xe: Use missing lock in relay_needs_worker
Date: Mon, 3 Jun 2024 10:17:23 +0200 [thread overview]
Message-ID: <20240603081723.18775-1-nirmoy.das@intel.com> (raw)
Add missing lock that is protecting relay->incoming_actions.
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/xe/xe_guc_relay.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_relay.c b/drivers/gpu/drm/xe/xe_guc_relay.c
index c3bbaf474f9a..ade6162dc259 100644
--- a/drivers/gpu/drm/xe/xe_guc_relay.c
+++ b/drivers/gpu/drm/xe/xe_guc_relay.c
@@ -761,7 +761,14 @@ static void relay_process_incoming_action(struct xe_guc_relay *relay)
static bool relay_needs_worker(struct xe_guc_relay *relay)
{
- return !list_empty(&relay->incoming_actions);
+ bool is_empty;
+
+ spin_lock(&relay->lock);
+ is_empty = list_empty(&relay->incoming_actions);
+ spin_unlock(&relay->lock);
+
+ return !is_empty;
+
}
static void relay_kick_worker(struct xe_guc_relay *relay)
--
2.42.0
next reply other threads:[~2024-06-03 8:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 8:17 Nirmoy Das [this message]
2024-06-03 9:02 ` ✓ CI.Patch_applied: success for drm/xe: Use missing lock in relay_needs_worker Patchwork
2024-06-03 9:02 ` ✓ CI.checkpatch: " Patchwork
2024-06-03 9:03 ` ✓ CI.KUnit: " Patchwork
2024-06-03 9:14 ` ✓ CI.Build: " Patchwork
2024-06-03 9:15 ` ✗ CI.Hooks: failure " Patchwork
2024-06-03 9:16 ` ✓ CI.checksparse: success " Patchwork
2024-06-03 9:56 ` ✓ CI.BAT: " Patchwork
2024-06-03 11:47 ` ✗ CI.FULL: failure " Patchwork
2024-06-05 8:58 ` Nirmoy Das
2024-06-03 14:19 ` [PATCH] " Michal Wajdeczko
2024-06-03 19:51 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603081723.18775-1-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox