Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, jonathan.cavitt@intel.com,
	matthew.brost@intel.com, john.c.harrison@intel.com,
	stuart.summers@intel.com
Subject: [PATCH] drm/xe/xe_guc_submit: Declare reset if guc stopped
Date: Mon,  3 Jun 2024 14:05:54 -0700	[thread overview]
Message-ID: <20240603210554.2458942-1-jonathan.cavitt@intel.com> (raw)

An exec queue should be considered reset if the guc it was running on
has had its submission state disabled, as this normally only occurs on
a reset.  So, add the condition to the reset_status guc_exec_queue_op.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: John Harrison <john.c.harrison@intel.com>
CC: Matthew Brost <matthew.brost@intel.com>
CC: Stuart Summers <stuart.summers@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index d9c159e3c5320..8c0b0c70fa5ea 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1414,7 +1414,8 @@ static void guc_exec_queue_resume(struct xe_exec_queue *q)
 
 static bool guc_exec_queue_reset_status(struct xe_exec_queue *q)
 {
-	return exec_queue_reset(q) || exec_queue_killed_or_banned_or_wedged(q);
+	return guc_read_stopped(exec_queue_to_guc(q)) ||
+	       exec_queue_reset(q) || exec_queue_killed_or_banned_or_wedged(q);
 }
 
 /*
-- 
2.25.1


             reply	other threads:[~2024-06-03 21:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-03 21:05 Jonathan Cavitt [this message]
2024-06-03 22:39 ` [PATCH] drm/xe/xe_guc_submit: Declare reset if guc stopped Matthew Brost
2024-06-04 15:00   ` Cavitt, Jonathan
2024-06-04 22:00 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-04 22:00 ` ✓ CI.checkpatch: " Patchwork
2024-06-04 22:01 ` ✓ CI.KUnit: " Patchwork
2024-06-04 22:12 ` ✓ CI.Build: " Patchwork
2024-06-04 22:13 ` ✗ CI.Hooks: failure " Patchwork
2024-06-04 22:14 ` ✓ CI.checksparse: success " Patchwork
2024-06-04 22:42 ` ✓ CI.BAT: " Patchwork
2024-06-05  5:43 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240603210554.2458942-1-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=stuart.summers@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox