Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Anshuman Gupta <anshuman.gupta@intel.com>,
	Francois Dugast <francois.dugast@intel.com>
Subject: [PATCH 2/2] drm/xe: Ensure d3cold is only allowed in DGFX
Date: Mon, 3 Jun 2024 17:52:18 -0400	[thread overview]
Message-ID: <20240603215218.14278-2-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20240603215218.14278-1-rodrigo.vivi@intel.com>

For our integrated parts, the GPU is part of the CPU package,
hence removing the power at the root port is likely not possible.

Let's add this extra layer of protection to ensure that we are
really not seeing d3cold atempts into integrated devices.

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index de3b5df65e48..1facb7dd8b66 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -172,6 +172,9 @@ static bool xe_pm_pci_d3cold_capable(struct xe_device *xe)
 	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
 	struct pci_dev *root_pdev;
 
+	if (!IS_DGFX(xe))
+		return false;
+
 	root_pdev = pcie_find_root_port(pdev);
 	if (!root_pdev)
 		return false;
-- 
2.45.1


  reply	other threads:[~2024-06-03 21:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-03 21:52 [PATCH 1/2] drm/xe: Avoid fbdev suspend at runtime pm suspend Rodrigo Vivi
2024-06-03 21:52 ` Rodrigo Vivi [this message]
2024-06-03 22:15   ` [PATCH 2/2] drm/xe: Ensure d3cold is only allowed in DGFX Zanoni, Paulo R
2024-06-04 15:03     ` Rodrigo Vivi
2024-06-04 22:46 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Avoid fbdev suspend at runtime pm suspend Patchwork
2024-06-04 22:47 ` ✓ CI.checkpatch: " Patchwork
2024-06-04 22:48 ` ✓ CI.KUnit: " Patchwork
2024-06-04 22:59 ` ✓ CI.Build: " Patchwork
2024-06-04 22:59 ` ✗ CI.Hooks: failure " Patchwork
2024-06-04 23:01 ` ✓ CI.checksparse: success " Patchwork
2024-06-04 23:29 ` ✓ CI.BAT: " Patchwork
2024-06-05  6:49 ` ✗ CI.FULL: failure " Patchwork
2024-06-07  8:59 ` [PATCH 1/2] " Francois Dugast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240603215218.14278-2-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox