From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E03BC27C52 for ; Thu, 6 Jun 2024 22:39:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 097EF10E1D6; Thu, 6 Jun 2024 22:39:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iI5Lrxs8"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00D3610E10F for ; Thu, 6 Jun 2024 22:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717713594; x=1749249594; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LZyuVdEPx6am7ndR4DIyYgso8WzQ8UrpI2Pox2sDcB4=; b=iI5Lrxs83dtbVZpkfJujiBCw4VldZJUlG0RWtpXoK++Ekk/2WWkcgwZn FUWXkt/m96d0+dGAVGeGbYcEHp2/TRCe5nbXmUai6XzaLgMx/E3iU/UO5 7Nrf9hUmvTnW8XnHS3wAfoGPkDUQ3E6Kgjm+GeNVqAGSrrtKsXUdRdiD5 1u+H+AeV+E5+Z+hKg4CXOgkoByYpNZuCa/ki7PRLu/eygh4CUmhwJl8cy 7NUoMxqoGRQE7oX+bt83FayuFXmrkmUMJZlXF9xk4Qs5BtAl5KmNYRIBy fI1HM0/uiRcxLOjEVKcDofE23ndnZIFsoKTp2j1K4f6sQvBld6DB5dO2G A==; X-CSE-ConnectionGUID: gXUE2HGDRwO79ufPWlGfLw== X-CSE-MsgGUID: EB5ht/m8QFiazOgzRDCVyw== X-IronPort-AV: E=McAfee;i="6600,9927,11095"; a="17346516" X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="17346516" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 15:39:53 -0700 X-CSE-ConnectionGUID: gpHaOIeUQuKvQenxdgAwyA== X-CSE-MsgGUID: /VPVwNFpS2ud8GPjgLS71A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="37966755" Received: from invictus.jf.intel.com ([10.165.21.201]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 15:39:52 -0700 From: Radhakrishna Sripada To: intel-xe@lists.freedesktop.org Cc: gustavo.sousa@intel.com, Radhakrishna Sripada Subject: [PATCH v5 0/6] Tracing cleanup and add mmio tracing Date: Thu, 6 Jun 2024 15:38:13 -0700 Message-Id: <20240606223819.3545560-1-radhakrishna.sripada@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" xe_trace.h is getting bloated. Group related events to their own files. All bo, vm and vma related events have been moved to xe_trace_bo.h. GuC related trace events have been moved to xe_trace_guc.h. Patches 1 and 2 splits the trace events into seperate files. In multi gpu environments, it is important to know the device from which the event was triggered. Print the device id information along with the trace information being printed. Patches 3, 4 and 5 make changes to print the device id's if not already captured. Mmio reg read writes are important tracing information that needs to be captured and will be helpful in display debug. Patch 6 adds the reg read/write tracing support. Earlier versions of patch 6 can be found here: v1: https://patchwork.freedesktop.org/series/119312/ v2: https://patchwork.freedesktop.org/series/132626/ v4: Fixes the review comments from Gustavo v5: Fixes the kunit error reported. Radhakrishna Sripada (6): drm/xe/trace: Extract bo, vm, vma traces drm/xe/trace: Extract guc related traces drm/xe/trace: Print device_id in xe_trace_bo events drm/xe/trace: Print device_id in xe_trace_guc events drm/xe/trace: Print device_id in xe_trace events drm/xe: Add reg read/write trace drivers/gpu/drm/xe/Makefile | 2 + drivers/gpu/drm/xe/xe_bo.c | 2 +- drivers/gpu/drm/xe/xe_gt_pagefault.c | 2 +- drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 27 +- drivers/gpu/drm/xe/xe_guc_ct.c | 13 +- drivers/gpu/drm/xe/xe_migrate.c | 2 +- drivers/gpu/drm/xe/xe_mmio.c | 24 +- drivers/gpu/drm/xe/xe_pt.c | 8 +- drivers/gpu/drm/xe/xe_trace.h | 381 ++++---------------- drivers/gpu/drm/xe/xe_trace_bo.c | 9 + drivers/gpu/drm/xe/xe_trace_bo.h | 248 +++++++++++++ drivers/gpu/drm/xe/xe_trace_guc.c | 9 + drivers/gpu/drm/xe/xe_trace_guc.h | 111 ++++++ drivers/gpu/drm/xe/xe_vm.c | 2 +- 14 files changed, 496 insertions(+), 344 deletions(-) create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.c create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.h create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.c create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.h -- 2.34.1