From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v2 0/6] Only timeout jobs if they run longer than timeout period
Date: Fri, 7 Jun 2024 15:03:08 -0700 [thread overview]
Message-ID: <20240607220314.2318154-1-matthew.brost@intel.com> (raw)
Debugging [1] hit a known flaw in the job timeout mechanism - jobs
timeout after a period of time in which they have been submitted to the
GuC not how long they have actually been running on the hardware.
Attempt to fix this.
Algorithm is as follows:
- Copy ctx timestamp from LRC to saved location at beginning of every
job
- On TDR kick jobs off hardware via schedule disable so ctx timestamp is
updated
- Compare ctx timestamp to saved ctx timestamp, if jobs having been
running less than timeout period re-enable scheduling are restart TDR
New job cancel IGT [2] for testing.
v2:
- Promote to non-RFC as issues which I view as blockers have been resolved
- Address Jani and Michal v1 feedback
- Add GT clock timer calculation
Matt
[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/799
[2] https://patchwork.freedesktop.org/series/134637/
Matthew Brost (6):
drm/xe: Add LRC ctx timestamp support functions
drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions
drm/xe: Emit ctx timestamp copy in ring ops
drm/xe: Add ctx timestamp to LRC snapshot
drm/xe: Add xe_gt_clock_interval_to_ms helper
drm/xe: Sample ctx timestamp to determine if jobs have timed out
.../gpu/drm/xe/instructions/xe_mi_commands.h | 4 +
drivers/gpu/drm/xe/xe_gt_clock.c | 18 +++
drivers/gpu/drm/xe/xe_gt_clock.h | 1 +
drivers/gpu/drm/xe/xe_guc_submit.c | 153 ++++++++++++++----
drivers/gpu/drm/xe/xe_lrc.c | 72 +++++++++
drivers/gpu/drm/xe/xe_lrc.h | 5 +
drivers/gpu/drm/xe/xe_ring_ops.c | 21 +++
7 files changed, 241 insertions(+), 33 deletions(-)
--
2.34.1
next reply other threads:[~2024-06-07 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 22:03 Matthew Brost [this message]
2024-06-07 22:03 ` [PATCH v2 1/6] drm/xe: Add LRC ctx timestamp support functions Matthew Brost
2024-06-07 22:03 ` [PATCH v2 2/6] drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions Matthew Brost
2024-06-07 22:03 ` [PATCH v2 3/6] drm/xe: Emit ctx timestamp copy in ring ops Matthew Brost
2024-06-07 22:03 ` [PATCH v2 4/6] drm/xe: Add ctx timestamp to LRC snapshot Matthew Brost
2024-06-07 22:03 ` [PATCH v2 5/6] drm/xe: Add xe_gt_clock_interval_to_ms helper Matthew Brost
2024-06-07 22:03 ` [PATCH v2 6/6] drm/xe: Sample ctx timestamp to determine if jobs have timed out Matthew Brost
2024-06-07 23:27 ` ✗ CI.Patch_applied: failure for Only timeout jobs if they run longer than timeout period (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607220314.2318154-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox