From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86A88C27C55 for ; Mon, 10 Jun 2024 16:11:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C3D2910E4CF; Mon, 10 Jun 2024 16:11:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eq3iEx3t"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03B0710E3C3 for ; Mon, 10 Jun 2024 16:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718035905; x=1749571905; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jthJjJ2zKTiLV2PBjpIfe6L6//S4w66QTWO5SgbSzSU=; b=eq3iEx3tAzPnjSEbZRXRu5hIQAVMzb1Pvj8MIpMg6tx+RMazSHzTKBo8 i6hsGGq+1eXHULXMBXUCkDronG0VXr5VXpbSbaSzpiEmmtaMwYyEAqk7a 4Z+X/HP6PvdMlJIH5+0bgyJo5Mv3I0SOD+P0iF6YCXJwc2L3YdZqn36h0 USDe1KoYDuElPJDjYfwKzD2BFrIdXqV5zt9Bkb1nZAC+XnJknUEubd4vQ E7LrMIhGHLUh0NYaZlkASaMS9r0wUVOKXKbFER5W4kHq5kSAecZsV4HaP 5wp43fg9buFFceMSF8pbIr1a1wZjd7ECvfXmbw/5Gshg0xNPC0j9fMR89 A==; X-CSE-ConnectionGUID: M5IEBjrwREmxroS55DbHAw== X-CSE-MsgGUID: nA+IYnqZQJOmhRVzo4dbMQ== X-IronPort-AV: E=McAfee;i="6600,9927,11099"; a="32193235" X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="32193235" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2024 09:11:45 -0700 X-CSE-ConnectionGUID: T1Eb7ZF/S9urMerLp+Am7g== X-CSE-MsgGUID: IkcbREIBTGWs8Dn1ZLkHMA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="62281526" Received: from josouza-mobl2.bz.intel.com ([10.87.243.88]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2024 09:11:43 -0700 From: =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= To: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Jonathan Cavitt , =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= Subject: [PATCH v5 2/2] drm/xe: Increase devcoredump timeout Date: Mon, 10 Jun 2024 09:11:33 -0700 Message-ID: <20240610161133.156566-2-jose.souza@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240610161133.156566-1-jose.souza@intel.com> References: <20240610161133.156566-1-jose.souza@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" 5 minutes is too short for a regular user to search and understand what he needs to do to report capture devcoredump and report a bug to us, so here increasing this timeout to 1 hour. Cc: Rodrigo Vivi Cc: Jonathan Cavitt Acked-by: Jonathan Cavitt Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/xe_devcoredump.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c index d7f2d19a77c10..62c2b10fbf1d2 100644 --- a/drivers/gpu/drm/xe/xe_devcoredump.c +++ b/drivers/gpu/drm/xe/xe_devcoredump.c @@ -53,6 +53,9 @@ #ifdef CONFIG_DEV_COREDUMP +/* 1 hour timeout */ +#define XE_COREDUMP_TIMEOUT_JIFFIES (60 * 60 * HZ) + static struct xe_device *coredump_to_xe(const struct xe_devcoredump *coredump) { return container_of(coredump, struct xe_device, devcoredump); @@ -247,8 +250,9 @@ void xe_devcoredump(struct xe_sched_job *job) drm_info(&xe->drm, "Check your /sys/class/drm/card%d/device/devcoredump/data\n", xe->drm.primary->index); - dev_coredumpm(xe->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL, - xe_devcoredump_read, xe_devcoredump_free); + dev_coredumpm_timeout(xe->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL, + xe_devcoredump_read, xe_devcoredump_free, + XE_COREDUMP_TIMEOUT_JIFFIES); } static void xe_driver_devcoredump_fini(void *arg) -- 2.45.2