Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v6 08/11] drm/xe: Add GuC state asserts to deregister_exec_queue
Date: Tue, 11 Jun 2024 07:40:50 -0700	[thread overview]
Message-ID: <20240611144053.2805091-9-matthew.brost@intel.com> (raw)
In-Reply-To: <20240611144053.2805091-1-matthew.brost@intel.com>

Will help catch bugs in GuC state machine.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index ab0dc93d7740..26c27ca51b2e 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1587,6 +1587,11 @@ static void deregister_exec_queue(struct xe_guc *guc, struct xe_exec_queue *q)
 		q->guc->id,
 	};
 
+	xe_gt_assert(guc_to_gt(guc), exec_queue_destroyed(q));
+	xe_gt_assert(guc_to_gt(guc), exec_queue_registered(q));
+	xe_gt_assert(guc_to_gt(guc), !exec_queue_pending_disable(q));
+	xe_gt_assert(guc_to_gt(guc), !exec_queue_pending_enable(q));
+
 	trace_xe_exec_queue_deregister(q);
 
 	xe_guc_ct_send_g2h_handler(&guc->ct, action, ARRAY_SIZE(action));
-- 
2.34.1


  parent reply	other threads:[~2024-06-11 14:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 14:40 [PATCH v6 00/11] Only timeout jobs if they run longer than timeout period Matthew Brost
2024-06-11 14:40 ` [PATCH v6 01/11] drm/xe: Add LRC ctx timestamp support functions Matthew Brost
2024-06-11 14:40 ` [PATCH v6 02/11] drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions Matthew Brost
2024-06-11 14:40 ` [PATCH v6 03/11] drm/xe: Emit ctx timestamp copy in ring ops Matthew Brost
2024-06-11 14:40 ` [PATCH v6 04/11] drm/xe: Add ctx timestamp to LRC snapshot Matthew Brost
2024-06-11 14:40 ` [PATCH v6 05/11] drm/xe: Add xe_gt_clock_interval_to_ms helper Matthew Brost
2024-06-11 14:40 ` [PATCH v6 06/11] drm/xe: Improve unexpected state error messages Matthew Brost
2024-06-11 14:40 ` [PATCH v6 07/11] drm/xe: Assert runnable state in handle_sched_done Matthew Brost
2024-06-11 15:19   ` Cavitt, Jonathan
2024-06-12 21:25   ` John Harrison
2024-06-12 22:27     ` Matthew Brost
2024-06-13  0:54       ` John Harrison
2024-06-13  1:47         ` Matthew Brost
2024-06-13  2:00           ` John Harrison
2024-06-11 14:40 ` Matthew Brost [this message]
2024-06-11 14:40 ` [PATCH v6 09/11] drm/xe: Add pending disable assert to handle_sched_done Matthew Brost
2024-06-11 14:40 ` [PATCH v6 10/11] drm/xe: Add killed, banned, or wedged as stick bit during GuC reset Matthew Brost
2024-06-11 14:40 ` [PATCH v6 11/11] drm/xe: Sample ctx timestamp to determine if jobs have timed out Matthew Brost
2024-06-12 21:56   ` John Harrison
2024-06-12 22:30     ` Matthew Brost
2024-06-13  0:57       ` John Harrison
2024-06-13  1:51         ` Matthew Brost
2024-08-28 19:23   ` Matt Roper
2024-09-30 20:55     ` Matt Roper
2024-06-11 15:42 ` ✓ CI.Patch_applied: success for Only timeout jobs if they run longer than timeout period Patchwork
2024-06-11 15:42 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-11 15:43 ` ✓ CI.KUnit: success " Patchwork
2024-06-11 15:59 ` ✓ CI.Build: " Patchwork
2024-06-11 16:01 ` ✗ CI.Hooks: failure " Patchwork
2024-06-11 16:03 ` ✓ CI.checksparse: success " Patchwork
2024-06-11 16:57 ` ✓ CI.BAT: " Patchwork
2024-06-11 19:11 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240611144053.2805091-9-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox