Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	John Harrison <John.C.Harrison@Intel.com>,
	Badal Nilawar <badal.nilawar@intel.com>
Subject: [PATCH 4/4] drm/xe/guc: Avoid named enum types in GuC KLV ABI
Date: Tue, 11 Jun 2024 20:07:35 +0200	[thread overview]
Message-ID: <20240611180735.1988-5-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240611180735.1988-1-michal.wajdeczko@intel.com>

The xe_guc_klv_ids name just for workaround keys is too generic,
as workaround keys are not the only keys used by the GuC firmware.
Other KLVs keys are defined as plain defines or anonymous enums.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 2 +-
 drivers/gpu/drm/xe/xe_guc_ads.c       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/abi/guc_klvs_abi.h b/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
index a0b80c9fc5ef..831a2b57f308 100644
--- a/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
+++ b/drivers/gpu/drm/xe/abi/guc_klvs_abi.h
@@ -346,7 +346,7 @@ enum {
 /*
  * Workaround keys:
  */
-enum xe_guc_klv_ids {
+enum {
 	GUC_WORKAROUND_KLV_BLOCK_INTERRUPTS_WHEN_MGSR_BLOCKED				= 0x9002,
 	GUC_WORKAROUND_KLV_ID_GAM_PFQ_SHADOW_TAIL_POLLING				= 0x9005,
 	GUC_WORKAROUND_KLV_ID_DISABLE_MTP_DURING_ASYNC_COMPUTE				= 0x9007,
diff --git a/drivers/gpu/drm/xe/xe_guc_ads.c b/drivers/gpu/drm/xe/xe_guc_ads.c
index 1c60b685dbc6..a3de00e92b4e 100644
--- a/drivers/gpu/drm/xe/xe_guc_ads.c
+++ b/drivers/gpu/drm/xe/xe_guc_ads.c
@@ -285,7 +285,7 @@ static size_t calculate_golden_lrc_size(struct xe_guc_ads *ads)
 }
 
 static void guc_waklv_enable_one_word(struct xe_guc_ads *ads,
-				      enum xe_guc_klv_ids klv_id,
+				      u16 klv_id,
 				      u32 value,
 				      u32 *offset, u32 *remain)
 {
@@ -312,7 +312,7 @@ static void guc_waklv_enable_one_word(struct xe_guc_ads *ads,
 }
 
 static void guc_waklv_enable_simple(struct xe_guc_ads *ads,
-				    enum xe_guc_klv_ids klv_id, u32 *offset, u32 *remain)
+				    u16 klv_id, u32 *offset, u32 *remain)
 {
 	u32 klv_entry[] = {
 		/* 16:16 key/length */
-- 
2.43.0


  parent reply	other threads:[~2024-06-11 18:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 18:07 [PATCH 0/4] More GuC ABI fixes Michal Wajdeczko
2024-06-11 18:07 ` [PATCH 1/4] drm/xe/guc: Fixup GuC KLV ABI kernel-doc annotations Michal Wajdeczko
2024-06-11 18:07 ` [PATCH 2/4] drm/xe/guc: Update GuC CTB Descriptor ABI Michal Wajdeczko
2024-06-11 18:07 ` [PATCH 3/4] drm/xe/guc: Fixup HXG Fast Request description Michal Wajdeczko
2024-06-11 18:07 ` Michal Wajdeczko [this message]
2024-06-11 20:16   ` [PATCH 4/4] drm/xe/guc: Avoid named enum types in GuC KLV ABI John Harrison
2024-06-11 21:14     ` Michal Wajdeczko
2024-06-12 20:50       ` John Harrison
2024-06-11 20:25 ` ✓ CI.Patch_applied: success for More GuC ABI fixes Patchwork
2024-06-11 20:26 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-11 20:27 ` ✓ CI.KUnit: success " Patchwork
2024-06-11 20:38 ` ✓ CI.Build: " Patchwork
2024-06-11 20:41 ` ✗ CI.Hooks: failure " Patchwork
2024-06-11 20:42 ` ✓ CI.checksparse: success " Patchwork
2024-06-11 21:24 ` ✓ CI.BAT: " Patchwork
2024-06-12  2:27 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240611180735.1988-5-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=John.C.Harrison@Intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox