Re: [PATCH] drm/xe/vf: Use correct check for being a VF driver

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on czw [2024-cze-13 14:07:49 +0200]:
> The IS_SRIOV macro returns true also when we are running as a PF
> driver. Use correct IS_SRIOV_VF macro to skip force-wake management.
> 
> Fixes: 513ea833c201 ("drm/xe/vf: Ignore force-wake requests if VF")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_force_wake.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c
> index 5db6926120c3..b263fff15273 100644
> --- a/drivers/gpu/drm/xe/xe_force_wake.c
> +++ b/drivers/gpu/drm/xe/xe_force_wake.c
> @@ -97,7 +97,7 @@ void xe_force_wake_init_engines(struct xe_gt *gt, struct xe_force_wake *fw)
>  
>  static void __domain_ctl(struct xe_gt *gt, struct xe_force_wake_domain *domain, bool wake)
>  {
> -	if (IS_SRIOV(gt_to_xe(gt)))
> +	if (IS_SRIOV_VF(gt_to_xe(gt)))
>  		return;
>  
>  	xe_mmio_write32(gt, domain->reg_ctl, domain->mask | (wake ? domain->val : 0));
> @@ -108,7 +108,7 @@ static int __domain_wait(struct xe_gt *gt, struct xe_force_wake_domain *domain,
>  	u32 value;
>  	int ret;
>  
> -	if (IS_SRIOV(gt_to_xe(gt)))
> +	if (IS_SRIOV_VF(gt_to_xe(gt)))
>  		return 0;
>  
>  	ret = xe_mmio_wait32(gt, domain->reg_ack, domain->val, wake ? domain->val : 0,

Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> -- 
> 2.43.0
> 

--