Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v4 3/7] drm/xe: Add xe_exec_queue_last_fence_test_dep
Date: Tue, 18 Jun 2024 10:15:05 -0700	[thread overview]
Message-ID: <20240618171509.3336601-4-matthew.brost@intel.com> (raw)
In-Reply-To: <20240618171509.3336601-1-matthew.brost@intel.com>

Helpful to determine if a bind can immediately use CPU or needs to be
deferred a drm scheduler job.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_exec_queue.c | 23 +++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_exec_queue.h |  2 ++
 2 files changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index 0ba37835849b..65b4d1da6c93 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -906,3 +906,26 @@ void xe_exec_queue_last_fence_set(struct xe_exec_queue *q, struct xe_vm *vm,
 	xe_exec_queue_last_fence_put(q, vm);
 	q->last_fence = dma_fence_get(fence);
 }
+
+/**
+ * xe_exec_queue_last_fence_test_dep - Test last fence dependency of queue
+ * @q: The exec queue
+ * @vm: The VM the engine does a bind or exec for
+ *
+ * Returns:
+ * 0 on success on dependency, -ETIME on dependency
+ */
+int xe_exec_queue_last_fence_test_dep(struct xe_exec_queue *q, struct xe_vm *vm)
+{
+	struct dma_fence *fence;
+	int err = 0;
+
+	fence = xe_exec_queue_last_fence_get(q, vm);
+	if (fence) {
+		err = test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags) ?
+			0 : -ETIME;
+		dma_fence_put(fence);
+	}
+
+	return err;
+}
diff --git a/drivers/gpu/drm/xe/xe_exec_queue.h b/drivers/gpu/drm/xe/xe_exec_queue.h
index 289a3a51d2a2..ded77b0f3b90 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.h
+++ b/drivers/gpu/drm/xe/xe_exec_queue.h
@@ -75,6 +75,8 @@ struct dma_fence *xe_exec_queue_last_fence_get(struct xe_exec_queue *e,
 					       struct xe_vm *vm);
 void xe_exec_queue_last_fence_set(struct xe_exec_queue *e, struct xe_vm *vm,
 				  struct dma_fence *fence);
+int xe_exec_queue_last_fence_test_dep(struct xe_exec_queue *q,
+				      struct xe_vm *vm);
 void xe_exec_queue_update_run_ticks(struct xe_exec_queue *q);
 
 #endif
-- 
2.34.1


  parent reply	other threads:[~2024-06-18 17:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 17:15 [PATCH v4 0/7] Convert multiple bind ops to 1 job Matthew Brost
2024-06-18 17:15 ` [PATCH v4 1/7] drm/xe: s/xe_tile_migrate_engine/xe_tile_migrate_exec_queue Matthew Brost
2024-06-18 17:15 ` [PATCH v4 2/7] drm/xe: Add xe_vm_pgtable_update_op to xe_vma_ops Matthew Brost
2024-06-18 17:15 ` Matthew Brost [this message]
2024-06-18 17:15 ` [PATCH v4 4/7] drm/xe: Convert multiple bind ops into single job Matthew Brost
2024-06-20 17:15   ` Matthew Auld
2024-06-20 18:52     ` Matthew Brost
2024-06-20 19:20       ` Matthew Brost
2024-06-21 15:23   ` Matthew Auld
2024-06-21 17:06     ` Matthew Brost
2024-06-18 17:15 ` [PATCH v4 5/7] drm/xe: Update VM trace events Matthew Brost
2024-06-18 17:15 ` [PATCH v4 6/7] drm/xe: Update PT layer with better error handling Matthew Brost
2024-06-21 14:37   ` Matthew Auld
2024-06-21 17:25     ` Matthew Brost
2024-06-18 17:15 ` [PATCH v4 7/7] drm/xe: Add VM bind IOCTL error injection Matthew Brost
2024-06-18 17:19 ` ✓ CI.Patch_applied: success for Convert multiple bind ops to 1 job (rev4) Patchwork
2024-06-18 17:19 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-18 17:20 ` ✓ CI.KUnit: success " Patchwork
2024-06-18 17:32 ` ✓ CI.Build: " Patchwork
2024-06-18 17:34 ` ✗ CI.Hooks: failure " Patchwork
2024-06-18 17:35 ` ✓ CI.checksparse: success " Patchwork
2024-06-18 17:58 ` ✗ CI.BAT: failure " Patchwork
2024-06-19  6:54 ` ✗ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240618171509.3336601-4-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox