From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH] drm/xe/oa: Fix kernel doc warnings in xe_drm.h
Date: Sat, 22 Jun 2024 08:51:31 -0700 [thread overview]
Message-ID: <20240622155131.3671979-1-ashutosh.dixit@intel.com> (raw)
Fix kernel doc warnings in xe_drm.h. Also make sure that private/non-abi
enum definitions are distinct from real enum definitions and don't generate
kernel doc.
Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/xe/xe_oa.c | 2 +-
include/uapi/drm/xe_drm.h | 9 ++++++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index 4168b51cf7b5..fe6e29fb06b7 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -1692,7 +1692,7 @@ static int xe_oa_user_extensions(struct xe_oa *oa, u64 extension, int ext_number
int err;
u32 idx;
- if (XE_IOCTL_DBG(oa->xe, ext_number >= DRM_XE_OA_PROPERTY_MAX))
+ if (XE_IOCTL_DBG(oa->xe, ext_number >= __DRM_XE_OA_PROPERTY_MAX))
return -E2BIG;
err = __copy_from_user(&ext, address, sizeof(ext));
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 93e00be44b2d..4dc90badce67 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -1379,8 +1379,11 @@ struct drm_xe_wait_user_fence {
* enum drm_xe_perf_type - Perf stream types
*/
enum drm_xe_perf_type {
+ /** @DRM_XE_PERF_TYPE_OA: OA perf stream type */
DRM_XE_PERF_TYPE_OA,
- __DRM_XE_PERF_TYPE_MAX, /* non-ABI */
+
+ /* private: non-ABI */
+ __DRM_XE_PERF_TYPE_MAX,
};
/**
@@ -1612,8 +1615,8 @@ enum drm_xe_oa_property_id {
*/
DRM_XE_OA_PROPERTY_OA_ENGINE_INSTANCE,
- /** @DRM_XE_OA_PROPERTY_MAX: non-ABI */
- DRM_XE_OA_PROPERTY_MAX
+ /* private: non-ABI */
+ __DRM_XE_OA_PROPERTY_MAX
};
/**
--
2.41.0
next reply other threads:[~2024-06-22 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 15:51 Ashutosh Dixit [this message]
2024-06-22 15:56 ` ✓ CI.Patch_applied: success for drm/xe/oa: Fix kernel doc warnings in xe_drm.h Patchwork
2024-06-22 15:56 ` ✓ CI.checkpatch: " Patchwork
2024-06-22 15:57 ` ✓ CI.KUnit: " Patchwork
2024-06-22 16:09 ` ✓ CI.Build: " Patchwork
2024-06-22 16:11 ` ✓ CI.Hooks: " Patchwork
2024-06-22 16:13 ` ✓ CI.checksparse: " Patchwork
2024-06-22 16:35 ` ✓ CI.BAT: " Patchwork
2024-06-22 18:00 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240622155131.3671979-1-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox