From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
Jose Souza <jose.souza@intel.com>
Subject: [PATCH 2/3] drm/xe: Exec queue op's to enable/disable preemption and timeslicing
Date: Tue, 25 Jun 2024 13:15:17 -0700 [thread overview]
Message-ID: <20240625201518.766925-3-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20240625201518.766925-1-ashutosh.dixit@intel.com>
Introduce set_no_preempt and clear_no_preempt exec queue ops.
set_no_preempt allows an exec queue to run uninterrupted (without
preemption or timeslicing). clear_no_preempt re-enables preemption and
timeslicing. The functionality is used in OA in the next patch.
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/xe/xe_exec_queue_types.h | 4 +++
drivers/gpu/drm/xe/xe_execlist.c | 14 ++++++++
drivers/gpu/drm/xe/xe_guc_submit.c | 45 ++++++++++++++++++++++++
3 files changed, 63 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
index 201588ec33c3..8d64c2277e96 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
+++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
@@ -164,6 +164,10 @@ struct xe_exec_queue_ops {
int (*set_timeslice)(struct xe_exec_queue *q, u32 timeslice_us);
/** @set_preempt_timeout: Set preemption timeout for exec queue */
int (*set_preempt_timeout)(struct xe_exec_queue *q, u32 preempt_timeout_us);
+ /** @set_no_preempt: Disable preemption and timeslicing for exec queue */
+ int (*set_no_preempt)(struct xe_exec_queue *q);
+ /** @clear_no_preempt: Re-enable preemption and timeslicing for exec queue */
+ int (*clear_no_preempt)(struct xe_exec_queue *q);
/**
* @suspend: Suspend exec queue from executing, allowed to be called
* multiple times in a row before resume with the caveat that
diff --git a/drivers/gpu/drm/xe/xe_execlist.c b/drivers/gpu/drm/xe/xe_execlist.c
index db906117db6d..04a2c7e86019 100644
--- a/drivers/gpu/drm/xe/xe_execlist.c
+++ b/drivers/gpu/drm/xe/xe_execlist.c
@@ -416,6 +416,18 @@ static int execlist_exec_queue_set_preempt_timeout(struct xe_exec_queue *q,
return 0;
}
+static int execlist_exec_queue_set_no_preempt(struct xe_exec_queue *q)
+{
+ /* NIY */
+ return 0;
+}
+
+static int execlist_exec_queue_clear_no_preempt(struct xe_exec_queue *q)
+{
+ /* NIY */
+ return 0;
+}
+
static int execlist_exec_queue_suspend(struct xe_exec_queue *q)
{
/* NIY */
@@ -446,6 +458,8 @@ static const struct xe_exec_queue_ops execlist_exec_queue_ops = {
.set_priority = execlist_exec_queue_set_priority,
.set_timeslice = execlist_exec_queue_set_timeslice,
.set_preempt_timeout = execlist_exec_queue_set_preempt_timeout,
+ .set_no_preempt = execlist_exec_queue_set_no_preempt,
+ .clear_no_preempt = execlist_exec_queue_clear_no_preempt,
.suspend = execlist_exec_queue_suspend,
.suspend_wait = execlist_exec_queue_suspend_wait,
.resume = execlist_exec_queue_resume,
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 373447758a60..3fd5523baf0f 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1548,6 +1548,49 @@ static int guc_exec_queue_set_preempt_timeout(struct xe_exec_queue *q,
return 0;
}
+static int guc_exec_queue_set_no_preempt(struct xe_exec_queue *q)
+{
+ struct xe_sched_msg *msg;
+
+ if ((!q->sched_props.preempt_timeout_us && !q->sched_props.timeslice_us) ||
+ exec_queue_killed_or_banned_or_wedged(q))
+ return 0;
+
+ msg = kmalloc(sizeof(*msg), GFP_KERNEL);
+ if (!msg)
+ return -ENOMEM;
+
+ /* Setting values to 0 will disable preemption and timeslicing */
+ q->sched_props.preempt_timeout_us = 0;
+ q->sched_props.timeslice_us = 0;
+
+ guc_exec_queue_add_msg(q, msg, SET_SCHED_PROPS);
+
+ return 0;
+}
+
+static int guc_exec_queue_clear_no_preempt(struct xe_exec_queue *q)
+{
+ struct xe_sched_msg *msg;
+
+ if ((q->sched_props.preempt_timeout_us ==
+ q->hwe->eclass->sched_props.preempt_timeout_us &&
+ q->sched_props.timeslice_us == q->hwe->eclass->sched_props.timeslice_us) ||
+ exec_queue_killed_or_banned_or_wedged(q))
+ return 0;
+
+ msg = kmalloc(sizeof(*msg), GFP_KERNEL);
+ if (!msg)
+ return -ENOMEM;
+
+ q->sched_props.preempt_timeout_us = q->hwe->eclass->sched_props.preempt_timeout_us;
+ q->sched_props.timeslice_us = q->hwe->eclass->sched_props.timeslice_us;
+
+ guc_exec_queue_add_msg(q, msg, SET_SCHED_PROPS);
+
+ return 0;
+}
+
static int guc_exec_queue_suspend(struct xe_exec_queue *q)
{
struct xe_sched_msg *msg = q->guc->static_msgs + STATIC_MSG_SUSPEND;
@@ -1598,6 +1641,8 @@ static const struct xe_exec_queue_ops guc_exec_queue_ops = {
.set_priority = guc_exec_queue_set_priority,
.set_timeslice = guc_exec_queue_set_timeslice,
.set_preempt_timeout = guc_exec_queue_set_preempt_timeout,
+ .set_no_preempt = guc_exec_queue_set_no_preempt,
+ .clear_no_preempt = guc_exec_queue_clear_no_preempt,
.suspend = guc_exec_queue_suspend,
.suspend_wait = guc_exec_queue_suspend_wait,
.resume = guc_exec_queue_resume,
--
2.41.0
next prev parent reply other threads:[~2024-06-25 20:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 20:15 [PATCH 0/3] drm/xe/oa: Add NO_PREEMPT property Ashutosh Dixit
2024-06-25 20:15 ` [PATCH 1/3] drm/xe/oa: Allow stream enable/disable functions to return error Ashutosh Dixit
2024-06-25 21:53 ` Umesh Nerlige Ramappa
2024-06-25 20:15 ` Ashutosh Dixit [this message]
2024-06-25 21:57 ` [PATCH 2/3] drm/xe: Exec queue op's to enable/disable preemption and timeslicing Umesh Nerlige Ramappa
2024-06-25 22:01 ` Matthew Brost
2024-06-26 0:24 ` Dixit, Ashutosh
2024-06-26 0:35 ` Matthew Brost
2024-06-25 20:15 ` [PATCH 3/3] drm/xe/oa: Allow preemption to be disabled on the stream exec queue Ashutosh Dixit
2024-06-25 20:49 ` Souza, Jose
2024-06-26 0:29 ` Dixit, Ashutosh
2024-06-25 21:55 ` Umesh Nerlige Ramappa
2024-06-25 22:02 ` Matthew Brost
2024-06-25 20:37 ` ✓ CI.Patch_applied: success for drm/xe/oa: Add NO_PREEMPT property (rev3) Patchwork
2024-06-25 20:37 ` ✓ CI.checkpatch: " Patchwork
2024-06-25 20:38 ` ✓ CI.KUnit: " Patchwork
2024-06-25 20:50 ` ✓ CI.Build: " Patchwork
2024-06-25 20:52 ` ✓ CI.Hooks: " Patchwork
2024-06-25 20:53 ` ✓ CI.checksparse: " Patchwork
2024-06-25 21:16 ` ✓ CI.BAT: " Patchwork
2024-06-26 1:48 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625201518.766925-3-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=lionel.g.landwerlin@intel.com \
--cc=matthew.brost@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox