Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI 1/2] drm/xe: Use a helper to get delta run ticks from the exec queue
Date: Fri, 28 Jun 2024 01:23:47 +0800	[thread overview]
Message-ID: <20240627172348.84991-2-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20240627172348.84991-1-umesh.nerlige.ramappa@intel.com>

As per earlier review feedback - code manipulating exec queue fields
should not be present in xe_device.c. Use a helper to get the delta run
ticks from exec queue.

v2: Drop the Fixes tag

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_drm_client.c |  7 ++-----
 drivers/gpu/drm/xe/xe_exec_queue.c | 18 ++++++++++++++++++
 drivers/gpu/drm/xe/xe_exec_queue.h |  1 +
 3 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_drm_client.c b/drivers/gpu/drm/xe/xe_drm_client.c
index 4a19b771e3a0..e0c4a50d372c 100644
--- a/drivers/gpu/drm/xe/xe_drm_client.c
+++ b/drivers/gpu/drm/xe/xe_drm_client.c
@@ -251,11 +251,8 @@ static void show_run_ticks(struct drm_printer *p, struct drm_file *file)
 
 	/* Accumulate all the exec queues from this client */
 	mutex_lock(&xef->exec_queue.lock);
-	xa_for_each(&xef->exec_queue.xa, i, q) {
-		xe_exec_queue_update_run_ticks(q);
-		xef->run_ticks[q->class] += q->run_ticks - q->old_run_ticks;
-		q->old_run_ticks = q->run_ticks;
-	}
+	xa_for_each(&xef->exec_queue.xa, i, q)
+		xef->run_ticks[q->class] += xe_exec_queue_delta_run_ticks(q);
 	mutex_unlock(&xef->exec_queue.lock);
 
 	/* Get the total GPU cycles */
diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index 0ba37835849b..4d90a16745d2 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -786,6 +786,24 @@ void xe_exec_queue_update_run_ticks(struct xe_exec_queue *q)
 	q->run_ticks += (new_ts - old_ts) * q->width;
 }
 
+/**
+ * xe_exec_queue_delta_run_ticks() - Get delta of queue run_ticks 
+ * @q: The exec queue
+ *
+ * Update run ticks for the specific queue and then return the delta when
+ * compared to the previous value of run ticks.
+ */
+u64 xe_exec_queue_delta_run_ticks(struct xe_exec_queue *q)
+{
+	u64 delta_ticks;
+
+	xe_exec_queue_update_run_ticks(q);
+	delta_ticks = q->run_ticks - q->old_run_ticks;
+	q->old_run_ticks = q->run_ticks;
+
+	return delta_ticks;
+}
+
 void xe_exec_queue_kill(struct xe_exec_queue *q)
 {
 	struct xe_exec_queue *eq = q, *next;
diff --git a/drivers/gpu/drm/xe/xe_exec_queue.h b/drivers/gpu/drm/xe/xe_exec_queue.h
index 289a3a51d2a2..42f683e5d88a 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.h
+++ b/drivers/gpu/drm/xe/xe_exec_queue.h
@@ -76,5 +76,6 @@ struct dma_fence *xe_exec_queue_last_fence_get(struct xe_exec_queue *e,
 void xe_exec_queue_last_fence_set(struct xe_exec_queue *e, struct xe_vm *vm,
 				  struct dma_fence *fence);
 void xe_exec_queue_update_run_ticks(struct xe_exec_queue *q);
+u64 xe_exec_queue_delta_run_ticks(struct xe_exec_queue *q);
 
 #endif
-- 
2.34.1


  reply	other threads:[~2024-06-27 17:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 17:23 [CI 0/2] Fixes and cleanup for per client utilization Umesh Nerlige Ramappa
2024-06-27 17:23 ` Umesh Nerlige Ramappa [this message]
2024-06-27 20:24   ` [CI 1/2] drm/xe: Use a helper to get delta run ticks from the exec queue Lucas De Marchi
2024-06-27 20:31     ` Umesh Nerlige Ramappa
2024-06-27 23:49       ` Umesh Nerlige Ramappa
2024-06-27 17:23 ` [CI 2/2] drm/xe: Get hwe domain specific FW to read RING_TIMESTAMP Umesh Nerlige Ramappa
2024-06-27 20:11   ` Lucas De Marchi
2024-06-27 17:29 ` ✓ CI.Patch_applied: success for Fixes and cleanup for per client utilization Patchwork
2024-06-27 17:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-27 17:30 ` ✓ CI.KUnit: success " Patchwork
2024-06-27 17:42 ` ✓ CI.Build: " Patchwork
2024-06-27 17:45 ` ✓ CI.Hooks: " Patchwork
2024-06-27 17:46 ` ✓ CI.checksparse: " Patchwork
2024-06-27 18:09 ` ✓ CI.BAT: " Patchwork
2024-06-27 20:46 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627172348.84991-2-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox