From: Uma Shankar <uma.shankar@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, daniele.ceraolospurio@intel.com,
vinay.belgaumkar@intel.com, Uma Shankar <uma.shankar@intel.com>
Subject: [PATCH] drm/xe/fbdev: Limit the usage of stolen for LNL+
Date: Thu, 11 Jul 2024 10:43:39 +0530 [thread overview]
Message-ID: <20240711051339.3289552-1-uma.shankar@intel.com> (raw)
As per recommendation in the workarounds:
WA_14021987551, Wa_16023588340:
There is an issue with accessing Stolen memory pages due a
hardware limitation. Limit the usage of stolen memory for
fbdev for LNL+. Don't use BIOS FB from stolen on LNL+ and
assign the same from system memory.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 10 +++++++++-
drivers/gpu/drm/xe/display/xe_plane_initial.c | 10 ++++++++++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
index 816ad13821a8..8fda8745ce0a 100644
--- a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
+++ b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
@@ -37,7 +37,14 @@ struct intel_framebuffer *intel_fbdev_fb_alloc(struct drm_fb_helper *helper,
size = PAGE_ALIGN(size);
obj = ERR_PTR(-ENODEV);
- if (!IS_DGFX(xe)) {
+ /*
+ * WA_14021987551, Wa_16023588340:
+ * There is an issue with accessing Stolen memory pages
+ * due a hardware limitation. Limit the usage of stolen
+ * memory for fbdev for LNL+. Don't use BIOS FB from
+ * stolen on LNL+ and assign the same from system memory
+ */
+ if (!IS_DGFX(xe) && (DISPLAY_VER(xe) < 20)) {
obj = xe_bo_create_pin_map(xe, xe_device_get_root_tile(xe),
NULL, size,
ttm_bo_type_kernel, XE_BO_FLAG_SCANOUT |
@@ -48,6 +55,7 @@ struct intel_framebuffer *intel_fbdev_fb_alloc(struct drm_fb_helper *helper,
else
drm_info(&xe->drm, "Allocated fbdev into stolen failed: %li\n", PTR_ERR(obj));
}
+
if (IS_ERR(obj)) {
obj = xe_bo_create_pin_map(xe, xe_device_get_root_tile(xe), NULL, size,
ttm_bo_type_kernel, XE_BO_FLAG_SCANOUT |
diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 5eccd6abb3ef..80dd6b64c921 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -104,6 +104,16 @@ initial_plane_bo(struct xe_device *xe,
phys_base = base;
flags |= XE_BO_FLAG_STOLEN;
+ /*
+ * WA_14021987551, Wa_16023588340:
+ * There is an issue with accessing Stolen memory pages
+ * due a hardware limitation. Limit the usage of stolen
+ * memory for fbdev for LNL+. Don't use BIOS FB from
+ * stolen on LNL+ and assign the same from system memory
+ */
+ if (DISPLAY_VER(xe) >= 20)
+ return NULL;
+
/*
* If the FB is too big, just don't use it since fbdev is not very
* important and we should probably use that space with FBC or other
--
2.42.0
next reply other threads:[~2024-07-11 5:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 5:13 Uma Shankar [this message]
2024-07-11 5:11 ` ✓ CI.Patch_applied: success for drm/xe/fbdev: Limit the usage of stolen for LNL+ Patchwork
2024-07-11 5:11 ` ✓ CI.checkpatch: " Patchwork
2024-07-11 5:12 ` ✓ CI.KUnit: " Patchwork
2024-07-11 5:24 ` ✓ CI.Build: " Patchwork
2024-07-11 5:26 ` ✓ CI.Hooks: " Patchwork
2024-07-11 5:28 ` ✓ CI.checksparse: " Patchwork
2024-07-11 5:52 ` ✓ CI.BAT: " Patchwork
2024-07-11 6:52 ` ✗ CI.FULL: failure " Patchwork
2024-07-11 16:31 ` [PATCH] " Lucas De Marchi
2024-07-11 17:38 ` Ville Syrjälä
2024-07-14 19:41 ` Shankar, Uma
2024-07-11 16:37 ` Matt Roper
2024-07-11 17:06 ` Lucas De Marchi
2024-07-14 19:49 ` Shankar, Uma
2024-07-14 19:46 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711051339.3289552-1-uma.shankar@intel.com \
--to=uma.shankar@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox