From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: [PATCH v3 1/3] drm/xe: Separate 64K physical allocation for display
Date: Thu, 11 Jul 2024 11:09:23 +0200 [thread overview]
Message-ID: <20240711090925.179366-2-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240711090925.179366-1-zbigniew.kempczynski@intel.com>
In case Tile4 + compression Battlemage requires physical 64K pages
for allocating display framebuffer. Add flag which distincts
buffer created for scanout from other buffers which don't need this
restriction.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/xe/xe_bo.c | 9 +++++++--
drivers/gpu/drm/xe/xe_device_types.h | 1 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 31192d983d9e..fbcf77698bf1 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -1984,9 +1984,13 @@ int xe_gem_create_ioctl(struct drm_device *dev, void *data,
if (args->flags & DRM_XE_GEM_CREATE_FLAG_DEFER_BACKING)
bo_flags |= XE_BO_FLAG_DEFER_BACKING;
- if (args->flags & DRM_XE_GEM_CREATE_FLAG_SCANOUT)
+ if (args->flags & DRM_XE_GEM_CREATE_FLAG_SCANOUT) {
bo_flags |= XE_BO_FLAG_SCANOUT;
+ if (xe->info.vram_flags & XE_VRAM_FLAGS_DISPLAY_NEED64K)
+ bo_flags |= XE_BO_NEEDS_64K;
+ }
+
bo_flags |= args->placement << (ffs(XE_BO_FLAG_SYSTEM) - 1);
if (args->flags & DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM) {
@@ -2315,8 +2319,9 @@ int xe_bo_dumb_create(struct drm_file *file_priv,
uint32_t handle;
int cpp = DIV_ROUND_UP(args->bpp, 8);
int err;
+ u8 flags_64k = XE_VRAM_FLAGS_NEED64K | XE_VRAM_FLAGS_DISPLAY_NEED64K;
u32 page_size = max_t(u32, PAGE_SIZE,
- xe->info.vram_flags & XE_VRAM_FLAGS_NEED64K ? SZ_64K : SZ_4K);
+ xe->info.vram_flags & flags_64k ? SZ_64K : SZ_4K);
args->pitch = ALIGN(args->width * cpp, 64);
args->size = ALIGN(mul_u32_u32(args->pitch, args->height),
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index f0cf9020e463..386faaffac53 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -46,6 +46,7 @@ struct xe_pat_ops;
#define HAS_HECI_GSCFI(xe) ((xe)->info.has_heci_gscfi)
#define XE_VRAM_FLAGS_NEED64K BIT(0)
+#define XE_VRAM_FLAGS_DISPLAY_NEED64K BIT(1)
#define XE_GT0 0
#define XE_GT1 1
--
2.34.1
next prev parent reply other threads:[~2024-07-11 9:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 9:09 [PATCH v3 0/3] Restrict BMG to use 64K pages for scanout buffers Zbigniew Kempczyński
2024-07-11 9:09 ` Zbigniew Kempczyński [this message]
2024-07-11 9:09 ` [PATCH v3 2/3] drm/xe: Expose display alignment requirement Zbigniew Kempczyński
2024-07-11 21:44 ` Rodrigo Vivi
2024-07-12 9:00 ` Zbigniew Kempczyński
2024-07-12 9:23 ` Zbigniew Kempczyński
2024-07-22 18:17 ` Rodrigo Vivi
2024-07-11 9:09 ` [PATCH v3 3/3] drm/xe: Use 64K pages for scanout buffers for Battlemage Zbigniew Kempczyński
2024-07-11 9:18 ` ✓ CI.Patch_applied: success for Restrict BMG to use 64K pages for scanout buffers (rev2) Patchwork
2024-07-11 9:19 ` ✓ CI.checkpatch: " Patchwork
2024-07-11 9:20 ` ✓ CI.KUnit: " Patchwork
2024-07-11 9:32 ` ✓ CI.Build: " Patchwork
2024-07-11 9:34 ` ✓ CI.Hooks: " Patchwork
2024-07-11 9:35 ` ✓ CI.checksparse: " Patchwork
2024-07-11 10:00 ` ✓ CI.BAT: " Patchwork
2024-07-11 11:09 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711090925.179366-2-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox